Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal Sinatra 1.x Appraisal #715

Merged
merged 2 commits into from
Nov 19, 2023
+27 −4
Merged

Removal Sinatra 1.x Appraisal #715

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e337e79
fix: Removal Sinatra 1.x Appraisal
zacheryph Nov 8, 2023
2308826
Merge branch 'main' into document-sinatra-1-support
arielvalentin Nov 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions instrumentation/rack/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,19 @@ gem install opentelemetry-instrumentation-rack

Or, if you use [bundler][bundler-home], include `opentelemetry-instrumentation-rack` in your `Gemfile`.

### Version Compatibility

Older versions of Rack are not supported by the latest version of this instrumentation. If you are using an older version of Rack and need an earlier version of this instrumentation, then consider installing and pinning the compatible gem version, e.g.:

```console
gem opentelemetry-instrumentation-rack, "<version>"
```

| Rack Version | Instrumentation Version |
| ------------ | ----------------------- |
| `< 2.0` | `= 0.22.1` |
| `>= 2.0` | `~> 0.23` |

## Usage

To use the instrumentation, call `use` with the name of the instrumentation:
Expand Down
4 changes: 0 additions & 4 deletions instrumentation/sinatra/Appraisals
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,3 @@ end
appraise 'sinatra-2.x' do
gem 'sinatra', '~> 2.1'
end

appraise 'sinatra-1.x' do
gem 'sinatra', '~> 1.4'
end
14 changes: 14 additions & 0 deletions instrumentation/sinatra/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,22 @@ Install the gem using:
gem install opentelemetry-instrumentation-sinatra
```


Or, if you use [bundler][bundler-home], include `opentelemetry-instrumentation-sinatra` to your `Gemfile`.

### Version Compatibility

Older versions of Sinatra depend on older version of Rack, which are not supported by the latest version of Rack instrumentation. If you are using an older version of Sinatra and need an earlier version of Rack instrumentation, then consider installing and pinning the compatible gem version, e.g.:

```console
gem opentelemetry-instrumentation-rack, "<version>"
```

| Sinatra Version | Rack Instrumentation Version |
| --------------- | ---------------------------- |
| `< 2.0` | `= 0.22.1` |
| `>= 2.0` | `~> 0.22` |

## Usage

To install the instrumentation, add the gem to your Gemfile:
Expand Down