test: Make Net::HTTP Deterministic #1390
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We would occasionally get errors where the test would attempt to make actual HTTP calls to example.com because dedpending on the order the tests would run WebMock would be configured to allow network calls. > OpenTelemetry::Instrumentation::Net::HTTP::Instrumentation::untraced?::untraced context#test_0002_no-ops on #connect: > Net::OpenTimeout: Failed to open TCP connection to example.com:80 (execution expired) https://github.com/open-telemetry/opentelemetry-ruby-contrib/actions/runs/13089176560/job/36523848687?pr=1388 This change ensures that WebMock is reset between test cases and raise an error when unexpected network requests occur.
arielvalentin
requested review from
fbogsany,
mwear,
robertlaurin,
dazuma,
ericmustin,
ahayworth,
plantfansam,
robbkidd,
simi,
kaylareopelle,
xuan-cao-swi and
a team
as code owners
|
The irony. 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We would occasionally get errors where the test would attempt to make actual HTTP calls to example.com because dedpending on the order the tests would run WebMock would be configured to allow network calls.
https://github.com/open-telemetry/opentelemetry-ruby-contrib/actions/runs/13089176560/job/36523848687?pr=1388
This change ensures that WebMock is reset between test cases and raise an error when unexpected network requests occur.