-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Use Block Argument Forwarding #1389
Open
arielvalentin
wants to merge
15
commits into
open-telemetry:main
Choose a base branch
from
arielvalentin:enable-arguement-forwarding-linter
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
refactor: Use Block Argument Forwarding #1389
arielvalentin
wants to merge
15
commits into
open-telemetry:main
from
arielvalentin:enable-arguement-forwarding-linter
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arielvalentin
requested review from
fbogsany,
mwear,
robertlaurin,
dazuma,
ericmustin,
ahayworth,
plantfansam,
robbkidd,
simi,
kaylareopelle,
xuan-cao-swi and
a team
as code owners
February 1, 2025 05:25
arielvalentin
force-pushed
the
enable-arguement-forwarding-linter
branch
from
February 1, 2025 13:22
ba5ee52
to
9ab562a
Compare
arielvalentin
changed the title
fix: Enable Argument Forwarding
refactor: Enable Argument Forwarding
Feb 1, 2025
> This cop identifies places where do_something(&block) can be replaced by do_something(&) https://docs.rubocop.org/rubocop/cops_style.html#styleargumentsforwarding https://docs.rubocop.org/rubocop/cops_naming.html#namingblockforwarding
arielvalentin
force-pushed
the
enable-arguement-forwarding-linter
branch
from
February 1, 2025 13:30
9ab562a
to
ff7c61e
Compare
arielvalentin
changed the title
refactor: Enable Argument Forwarding
refactor: Use Block Argument Forwading
Feb 1, 2025
arielvalentin
changed the title
refactor: Use Block Argument Forwading
refactor: Use Block Argument Forwarding
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://docs.rubocop.org/rubocop/cops_style.html#styleargumentsforwarding
https://docs.rubocop.org/rubocop/cops_naming.html#namingblockforwarding