Check for None result in gRPC (#3380)#3381
Merged
Conversation
ghost
self-requested a review
as a 
Contributor
|
Thanks for the PR, could you please write a test for this to avoid regressions in the future? |
Author
That was an adventure! Added a test that counts |
xrmx
reviewed
Mar 26, 2025
xrmx
reviewed
Mar 26, 2025
xrmx
reviewed
Apr 18, 2025
xrmx
moved this from Reviewed PR that needs fixing
to Easy to review / merge / close
in Python PR digest
xrmx
approved these changes
Apr 18, 2025
Contributor
xrmx
left a comment
xrmx
left a comment
There was a problem hiding this comment.
With the small nit fixed, LGTM
xrmx
reviewed
Apr 18, 2025
added 7 commits
April 18, 2025 13:09
lzchen
approved these changes
Apr 21, 2025
github-project-automation
Bot
moved this from Easy to review / merge / close
to Done
in Python PR digest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a fix for #3380 that checks explicitly for a
Noneresult rather than evaluating truthiness. PubSub results with zero messages evaluate toFalse, causingspan.end()to be called twice.Fixes #3380
Type of change
How Has This Been Tested?
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.