Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Support for kubernetes 1.32 version #3544

Merged
merged 5 commits into from
Jan 2, 2025

Conversation

vasireddy99
Copy link
Contributor

Description:
Support for kubernetes 1.32 version

@vasireddy99 vasireddy99 requested a review from a team as a code owner December 13, 2024 06:31
@vasireddy99 vasireddy99 force-pushed the operator32 branch 2 times, most recently from ce74293 to b7819bc Compare December 13, 2024 07:42
Copy link
Contributor

@swiatekm swiatekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like envtest doesn't support 1.32 yet, so our controller tests can't run against it. We can either go back to 1.31 in the Makefile and open an issue to update it once envtest adds support, or just hold this whole PR until then.

@open-telemetry/operator-maintainers WDYT?

@pavolloffay
Copy link
Member

I would wait until it is supported by the envtest

@frzifus
Copy link
Member

frzifus commented Dec 19, 2024

Another option would be to add another run on 32.0-rc0 until envtest with 1.32 exists.

@vasireddy99
Copy link
Contributor Author

vasireddy99 commented Dec 30, 2024

Looks like envtest doesn't support 1.32 yet, so our controller tests can't run against it. We can either go back to 1.31 in the Makefile and open an issue to update it once envtest adds support, or just hold this whole PR until then.

@open-telemetry/operator-maintainers WDYT?

PR is now ready for review @open-telemetry/operator-maintainers

@swiatekm swiatekm self-requested a review December 31, 2024 11:06
Copy link
Contributor

@swiatekm swiatekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@swiatekm swiatekm requested a review from a team December 31, 2024 11:08
@vasireddy99
Copy link
Contributor Author

Looks like envtest doesn't support 1.32 yet, so our controller tests can't run against it. We can either go back to 1.31 in the Makefile and open an issue to update it once envtest adds support, or just hold this whole PR until then.
@open-telemetry/operator-maintainers WDYT?

PR is now ready for review @open-telemetry/operator-maintainers

thanks for the approval, guess it is ready to merge

@swiatekm swiatekm merged commit 25c5cfa into open-telemetry:main Jan 2, 2025
38 checks passed
@vasireddy99 vasireddy99 deleted the operator32 branch January 2, 2025 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants