-
Notifications
You must be signed in to change notification settings - Fork 828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sdk-*)!: align merge resource behavior with spec #5219
feat(sdk-*)!: align merge resource behavior with spec #5219
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5219 +/- ##
==========================================
- Coverage 94.63% 94.62% -0.01%
==========================================
Files 323 323
Lines 8083 8068 -15
Branches 1643 1637 -6
==========================================
- Hits 7649 7634 -15
Misses 434 434
|
experimental/packages/opentelemetry-exporter-metrics-otlp-grpc/test/OTLPMetricExporter.test.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Marc Pichler <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for working on this 🙌
Just one question about the NodeSDK implementation of this.
just needs to be re-targeted to |
done! |
Which problem is this PR solving?
Aligns SDKs resource merging strategy with the specification:
Fixes #5132
Short description of the changes
mergeResourcesWithDefault
optionType of change
Please delete options that are not relevant.
How Has This Been Tested?
Compiled and ran the tests in all packages.
Checklist: