Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws-sdk): use custom client_context prop #2718

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

smoke
Copy link

@smoke smoke commented Feb 16, 2025

Which problem is this PR solving?

In every other language the respected property carrying the context is custom e.g.

Short description of the changes

  • rename Custom to custom property that is used as context carrier for AWS Lambda Client Context

@smoke smoke force-pushed the fix/opentelemetry-instrumentation-aws-lambda-inject-into-proper-custom-prop branch from faf6b56 to db2b6c2 Compare February 17, 2025 11:54
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.41%. Comparing base (e713796) to head (db2b6c2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2718   +/-   ##
=======================================
  Coverage   92.41%   92.41%           
=======================================
  Files         171      171           
  Lines        8150     8150           
  Branches     1653     1653           
=======================================
  Hits         7532     7532           
  Misses        618      618           
Files with missing lines Coverage Δ
...try-instrumentation-aws-sdk/src/services/lambda.ts 97.77% <ø> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants