-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(auto-instrumentations-node): enable runtime-node #2524
base: main
Are you sure you want to change the base?
feat(auto-instrumentations-node): enable runtime-node #2524
Conversation
|
441d85f
to
d013655
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2524 +/- ##
=======================================
Coverage 90.75% 90.75%
=======================================
Files 169 169
Lines 8018 8019 +1
Branches 1632 1632
=======================================
+ Hits 7277 7278 +1
Misses 741 741
|
Hi, would be good to have this merged and released. |
This PR needs approval from the owner of the instrumentation, cc @d4nyll - having it in the auto-instrumentation package and enabled by default will likely mean more users, which means often means that additional maintenance effort is required. |
@pichlermarc Happy to handle any additional maintenance work |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I support adding this instrumentation to the auto instrumentation package
@romancepenguin please resolve the conflicts, then we can merge this in 🙂 |
Which problem is this PR solving?
Short description of the changes