Skip to content

feat: Link the instrumented binary and run it and further check output content #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yuluo-yx wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: Link the instrumented binary and run it and further check output content #171

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
10a4443
feat: Link the instrumented binary and run it and further check outpu…
yuluo-yx Nov 15, 2025
0bd554b
Merge branch 'main' into 1115-yuluo/feat
yuluo-yx Nov 17, 2025
f683611
feat: add TestInstrumentWithHooks test
yuluo-yx Nov 17, 2025
4d04489
Merge branch 'main' into 1115-yuluo/feat
yuluo-yx Nov 18, 2025
25456f9
Merge branch 'main' into 1115-yuluo/feat
kakkoyun Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
89 changes: 17 additions & 72 deletions tool/internal/instrument/instrument_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,23 @@ func TestInstrument(t *testing.T) {
} else {
require.NoError(t, err)
}
// TODO: Link the instrumented binary and run it and further check
// output content
// Build the instrumented binary and run it, then verify output
binPath := filepath.Join(tempDir, "app")
buildCmd := exec.Command("go", "build", "-o", binPath, ".")
buildCmd.Dir = tempDir
buildCmd.Env = append(os.Environ(), "GO111MODULE=off")
out, err := buildCmd.CombinedOutput()
require.NoErrorf(t, err, "go build failed: %s", string(out))

runCmd := exec.Command(binPath)
runtimeOut, err := runCmd.CombinedOutput()
require.NoErrorf(t, err, "running app failed: %s", string(runtimeOut))

output := string(runtimeOut)
// Base output from source.go
require.Contains(t, output, "Hello, World!")
// Output from added raw rule newfile.go(func2)
require.Contains(t, output, "func2")
})
}
}
Expand Down Expand Up @@ -112,59 +127,6 @@ func createTestRuleJSON(mainGoFile string) ([]byte, error) {
{
PackageName: "main",
ModulePath: "main",
FuncRules: map[string][]*rule.InstFuncRule{
mainGoFile: {
{
InstBaseRule: rule.InstBaseRule{
Name: "hook_func",
Target: "main",
},
Path: filepath.Join(".", "testdata"),
Func: "Func1",
Before: "H1Before",
After: "H1After",
},
{
InstBaseRule: rule.InstBaseRule{
Name: "hook_same_func",
Target: "main",
},
Path: filepath.Join(".", "testdata"),
Func: "Func1",
Before: "H2Before",
After: "H2After",
},
{
InstBaseRule: rule.InstBaseRule{
Name: "hook_func_with_recv",
Target: "main",
},
Path: filepath.Join(".", "testdata"),
Func: "Func1",
Recv: "*T",
Before: "H3Before",
},
{
InstBaseRule: rule.InstBaseRule{
Name: "hook_func_no_before",
Target: "main",
},
Path: filepath.Join(".", "testdata"),
Func: "Func1",
Recv: "*T",
After: "H3After",
},
{
InstBaseRule: rule.InstBaseRule{
Name: "underscore_param",
Target: "main",
},
Path: filepath.Join(".", "testdata"),
Func: "Func2",
Before: "H4Before",
},
},
},
RawRules: map[string][]*rule.InstRawRule{
mainGoFile: {
{
Expand All @@ -177,23 +139,6 @@ func createTestRuleJSON(mainGoFile string) ([]byte, error) {
},
},
},
StructRules: map[string][]*rule.InstStructRule{
mainGoFile: {
{
InstBaseRule: rule.InstBaseRule{
Name: "add_new_field",
Target: "main",
},
Struct: "T",
NewField: []*rule.InstStructField{
{
Name: "NewField",
Type: "string",
},
},
},
},
},
FileRules: []*rule.InstFileRule{
{
InstBaseRule: rule.InstBaseRule{
Expand Down