-
Notifications
You must be signed in to change notification settings - Fork 500
[BUILD] upgrade googletest and benchmark to the latest releases supporting C++14 #3607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUILD] upgrade googletest and benchmark to the latest releases supporting C++14 #3607
Conversation
✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.
|
CI tests will fail when built with C++14 and the latest versions of googletest (v1.17.0). That upgrade will depend on bumping the minimum C++ version to C++17.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3607 +/- ##
==========================================
- Coverage 90.08% 90.05% -0.02%
==========================================
Files 220 220
Lines 7081 7081
==========================================
- Hits 6378 6376 -2
- Misses 703 705 +2 🚀 New features to boost your workflow:
|
|
||
bazel_dep(name = "google_benchmark", version = "1.8.3", dev_dependency = True, repo_name = "com_github_google_benchmark") | ||
bazel_dep(name = "googletest", version = "1.14.0.bcr.1", dev_dependency = True, repo_name = "com_google_googletest") | ||
bazel_dep(name = "google_benchmark", version = "1.9.0", dev_dependency = True, repo_name = "com_github_google_benchmark") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason these changes are triggering the bazel asan test to fail on compilation.
One issue is that the 20250127.0 version of abseil is being pulled in which only supports c++17.
2025/08/23 20:46:19 Downloading https://releases.bazel.build/7.1.1/release/bazel-7.1.1-linux-x86_64...
Starting local Bazel server and connecting to it...
Computing main repo mapping:
Computing main repo mapping:
Computing main repo mapping:
Computing main repo mapping:
WARNING: For repository 'com_google_absl', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph.
WARNING: For repository 'bazel_skylib', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph.
WARNING: For repository 'com_github_grpc_grpc', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph.
WARNING: For repository 'platforms', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph.
WARNING: For repository 'com_google_protobuf', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph.
WARNING: For repository 'rules_proto', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph.
Closing in favor of #3685 |
Contributes to #3525
Upgrade googletest and benchmark to the latest versions that support C++14.
Changes
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes