Skip to content

Conversation

dbarker
Copy link
Member

@dbarker dbarker commented Aug 22, 2025

Contributes to #3525

Upgrade googletest and benchmark to the latest versions that support C++14.

Changes

  • upgrade googletest to 1.16.0
  • upgrade benchmark to 1.9.0

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

Copy link

netlify bot commented Aug 22, 2025

Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit 7734be9
🔍 Latest deploy log https://app.netlify.com/projects/opentelemetry-cpp-api-docs/deploys/68aa18be70b24400071ce93e

@dbarker
Copy link
Member Author

dbarker commented Aug 22, 2025

CI tests will fail when built with C++14 and the latest versions of googletest (v1.17.0). That upgrade will depend on bumping the minimum C++ version to C++17.

external/googletest~/googletest/include/gtest/internal/gtest-port.h:273:2: error: #error C++ versions less than C++17 are not supported.
  273 | #error C++ versions less than C++17 are not supported.
      |  ^~~~~

Copy link

codecov bot commented Aug 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.05%. Comparing base (6bc8349) to head (eb893ee).
⚠️ Report is 32 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3607      +/-   ##
==========================================
- Coverage   90.08%   90.05%   -0.02%     
==========================================
  Files         220      220              
  Lines        7081     7081              
==========================================
- Hits         6378     6376       -2     
- Misses        703      705       +2     

see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dbarker dbarker changed the title [BUILD] upgrade googletest and benchmark to the latest releases [BUILD] upgrade googletest and benchmark to the latest releases supporting C++14 Aug 23, 2025

bazel_dep(name = "google_benchmark", version = "1.8.3", dev_dependency = True, repo_name = "com_github_google_benchmark")
bazel_dep(name = "googletest", version = "1.14.0.bcr.1", dev_dependency = True, repo_name = "com_google_googletest")
bazel_dep(name = "google_benchmark", version = "1.9.0", dev_dependency = True, repo_name = "com_github_google_benchmark")
Copy link
Member Author

@dbarker dbarker Aug 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason these changes are triggering the bazel asan test to fail on compilation.

One issue is that the 20250127.0 version of abseil is being pulled in which only supports c++17.

2025/08/23 20:46:19 Downloading https://releases.bazel.build/7.1.1/release/bazel-7.1.1-linux-x86_64...
Starting local Bazel server and connecting to it...
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
WARNING: For repository 'com_google_absl', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph.
WARNING: For repository 'bazel_skylib', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph.
WARNING: For repository 'com_github_grpc_grpc', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph.
WARNING: For repository 'platforms', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph.
WARNING: For repository 'com_google_protobuf', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph.
WARNING: For repository 'rules_proto', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph.

@dbarker dbarker added the pr:do-not-merge This PR is not ready to be merged. label Aug 24, 2025
@dbarker
Copy link
Member Author

dbarker commented Oct 4, 2025

Closing in favor of #3685

@dbarker dbarker closed this Oct 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:do-not-merge This PR is not ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant