Add Zap as the default error log in confighttp

[tarun-kavipurapu]

Description

This Issue Fixes the Issue #11820
This is a continuation pull request for #11830

Fixes #11820
-Made the Zap as the default ErrorLog Supplied to the Http server

[dmathieu]

We should return errors as soon as they happen, not later.

Suggested change

	errorLog, err := zap.NewStdLogAt(settings.Logger, zapcore.ErrorLevel)
	errorLog, err := zap.NewStdLogAt(settings.Logger, zapcore.ErrorLevel)
	if err != nil {
	return nil, err
	}

[tarun-kavipurapu]

the suggested change was the initial code too
but in
https://github.com/open-telemetry/opentelemetry-collector/pull/11830/files/71c16e0b293b4d6ed25146c4dd295093e672afd7#r1880527497
it was suggested to return server,err so that to avoid coverage report failures.

[dmathieu]

Then, how about something like:

server := &http.Server{
	Handler:           handler,
	ReadTimeout:       hss.ReadTimeout,
	ReadHeaderTimeout: hss.ReadHeaderTimeout,
	WriteTimeout:      hss.WriteTimeout,
	IdleTimeout:       hss.IdleTimeout,
}

errorLog, err := zap.NewStdLogAt(settings.Logger, zapcore.ErrorLevel)
if err != nil {
	return server, err
}

server.ErrorLog = errorLog
return server, nil

Then, we can handle multiple things that could return errors, and we also keep error return alongside its definition.

[tarun-kavipurapu]

I will check the report locally and may be make the change according to it
the command for it is make gotest-with-cover right?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.59%. Comparing base (4fc50a8) to head (58267e5).
Report is 199 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #11935   +/-   ##
=======================================
  Coverage   91.59%   91.59%           
=======================================
  Files         448      448           
  Lines       23759    23761    +2     
=======================================
+ Hits        21761    21763    +2     
  Misses       1623     1623           
  Partials      375      375           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[tarun-kavipurapu]

@dmathieu @dmitryax Hey any reason this is waiting to be merged i mean am i expected to make any changes?

[dmathieu]

This is waiting for a review/approval by an approver.

[github-actions]

This PR was marked stale due to lack of activity. It will be closed in 14 days.

[github-actions]

Closed as inactive. Feel free to reopen if this PR is still being worked on.