-
Notifications
You must be signed in to change notification settings - Fork 668
Suppression file update after ppc64le constant-time check #1041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The new BIKE code has some non-constant time subroutines for some platforms, but there's definitely an attempt to be constant time on recent Intel CPUs. It will take quite a bit of work to fully document this. Before we start, it also looks like we're not always using the best BIKE code available. For instance we're using |
Should we create a separate issue to track this, allowing us to merge this PR without waiting on that? |
I can remove the BIKE part from this PR, so this can be tracked and handled in a separate issue. |
|
Removed the BIKE part of this PR for the time being. |
|
Is this ready to merge? |
|
yes, it's ready from my side. |
|
Replaced by #1048 (with branch on open-quantum-safe project to be able to test TravisCI) |
Minor suppression file updates after a constant-time check on ppc64le (see #1037):
Adds the new BIKE variants (adding to issues.json like the previous variants, expert review might be needed here)The CI log with BIKE and Dilithium reports is available here: ppc64le.txt
The SPHINCS+ reports are documented separately in #1038.
The reported issues (except #1038) should also be reproducible using the
constant-time-x64-extensions/constant-time-x64circleci jobs. After this fix, all constant-time checks pass on x86_64 / ppc64le. BIKE will have to be added separately after this PR.