Conversation
Signed-off-by: Michael Lautrup <mpp@bankdata.dk>
bdumpp
force-pushed
the
issue-431-clean-up-bundle-secret-links
branch
from
October 1, 2026 11:42
b79f23c to
acb693c
Compare
srenatus
approved these changes
Oct 1, 2026
srenatus
left a comment
srenatus
left a comment
Contributor
There was a problem hiding this comment.
Thanks for contributing! LGTM 馃巿
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
馃挕Reason for Change
Updating a bundle or source to reference a different credentials secret leaves the previous relation in the database. The stale link can keep the old secret in use and prevents deleting it.
Fixes #431.
馃摑 Description of Change
Track the active secret IDs while upserting bundles and sources, then remove stale relation rows with the existing
deleteNotInhelper. This also removes the relation when credentials are removed.Add database regression coverage for bundle and source credential changes and removals, plus a CLI end-to-end test covering the bundle API flow