Skip to content

Conversation

@JaydipGabani
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) does this PR fix (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #

Special notes for your reviewer:

Signed-off-by: Jaydip Gabani <[email protected]>
@Copilot Copilot AI review requested due to automatic review settings August 7, 2025 19:59
@JaydipGabani JaydipGabani requested a review from a team as a code owner August 7, 2025 19:59
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds comprehensive documentation for GitHub Copilot agents working with the OPA Gatekeeper Library project. The documentation provides detailed instructions for understanding the project structure, build processes, and development workflows.

  • Adds agent-specific documentation covering project overview, build commands, and development workflows
  • Documents dual-engine policy support (Rego and CEL) with specific testing procedures
  • Provides comprehensive troubleshooting and validation command sequences

JaydipGabani and others added 3 commits August 7, 2025 20:03
Comment on lines +304 to +307
- **Performance-critical policies** (CEL is faster)
- **Simple validation logic** (CEL syntax is more straightforward)
- **Kubernetes-native deployments** (CEL doesn't require OPA runtime)
- **Future-proofing** (CEL is Kubernetes' strategic direction)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't think these are needed since we always want to add for non-referential and non-external data

# Run policy tests (requires OPA and gator CLI)
./test.sh
make verify-gator-dockerized POLICY_ENGINE=rego
make verify-gator-dockerized POLICY_ENGINE=cel
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we still need POLICY_ENGINE

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we default to cel now, I think its a good idea to keep this so the changes are tested for both regardless to make sure error rate is kept as low as possible.

Copy link
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments, otherwise lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants