-
Notifications
You must be signed in to change notification settings - Fork 339
chore: adding agents.md for copilot #676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
chore: adding agents.md for copilot #676
Conversation
Signed-off-by: Jaydip Gabani <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds comprehensive documentation for GitHub Copilot agents working with the OPA Gatekeeper Library project. The documentation provides detailed instructions for understanding the project structure, build processes, and development workflows.
- Adds agent-specific documentation covering project overview, build commands, and development workflows
- Documents dual-engine policy support (Rego and CEL) with specific testing procedures
- Provides comprehensive troubleshooting and validation command sequences
Signed-off-by: Jaydip Gabani <[email protected]>
Co-authored-by: Copilot <[email protected]> Signed-off-by: Jaydip Gabani <[email protected]>
| - **Performance-critical policies** (CEL is faster) | ||
| - **Simple validation logic** (CEL syntax is more straightforward) | ||
| - **Kubernetes-native deployments** (CEL doesn't require OPA runtime) | ||
| - **Future-proofing** (CEL is Kubernetes' strategic direction) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't think these are needed since we always want to add for non-referential and non-external data
| # Run policy tests (requires OPA and gator CLI) | ||
| ./test.sh | ||
| make verify-gator-dockerized POLICY_ENGINE=rego | ||
| make verify-gator-dockerized POLICY_ENGINE=cel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we still need POLICY_ENGINE
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we default to cel now, I think its a good idea to keep this so the changes are tested for both regardless to make sure error rate is kept as low as possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor comments, otherwise lgtm
What this PR does / why we need it:
Which issue(s) does this PR fix (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #
Special notes for your reviewer: