Skip to content

Conversation

@PierrePIRONIN
Copy link

What this PR does / why we need it:
Fixes a case sensitive test concerning the drop of ALL/all capability.

Which issue(s) does this PR fix (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #668

Special notes for your reviewer:

@PierrePIRONIN PierrePIRONIN requested a review from a team as a code owner July 15, 2025 09:07
Copy link
Contributor

@JaydipGabani JaydipGabani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! can you also add example to test this?

@PierrePIRONIN PierrePIRONIN force-pushed the fix/all-capa-case-sensitive branch 2 times, most recently from 654392a to 2d408a3 Compare July 25, 2025 08:04
Copy link
Contributor

@JaydipGabani JaydipGabani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm after below change, Thanks for working on this.

@PierrePIRONIN PierrePIRONIN force-pushed the fix/all-capa-case-sensitive branch from 2d408a3 to e00d6ec Compare July 29, 2025 07:25
@JaydipGabani
Copy link
Contributor

@PierrePIRONIN you need to sign the commit to fix DCO CI error.

@PierrePIRONIN PierrePIRONIN force-pushed the fix/all-capa-case-sensitive branch 2 times, most recently from 703ede8 to 72751e0 Compare September 2, 2025 13:32
@PierrePIRONIN
Copy link
Author

@JaydipGabani done

Copy link
Contributor

@JaydipGabani JaydipGabani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm after nits. Please fix nits.

@PierrePIRONIN PierrePIRONIN force-pushed the fix/all-capa-case-sensitive branch from 2e5aa33 to 4b545ab Compare September 23, 2025 07:41
@PierrePIRONIN
Copy link
Author

@JaydipGabani done and rebased on master. Ready to merge.

@JaydipGabani
Copy link
Contributor

@PierrePIRONIN Please run 'make generate generate-website-docs generate-artifacthub-artifacts' to generate the templates and docs to fix CI.

Signed-off-by: Pierre PIRONIN DUGNE <[email protected]>
@PierrePIRONIN PierrePIRONIN force-pushed the fix/all-capa-case-sensitive branch from f8e012e to 0b1b998 Compare September 24, 2025 07:00
@PierrePIRONIN
Copy link
Author

@JaydipGabani done

@PierrePIRONIN
Copy link
Author

@JaydipGabani is it ok for you ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

missingDropCapabilitiesByContainer should work with both 'all' and 'ALL'

2 participants