-
Notifications
You must be signed in to change notification settings - Fork 339
fix: drop capability shoud be tested without case sensitivity #670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix: drop capability shoud be tested without case sensitivity #670
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! can you also add example to test this?
654392a to
2d408a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm after below change, Thanks for working on this.
2d408a3 to
e00d6ec
Compare
|
@PierrePIRONIN you need to sign the commit to fix DCO CI error. |
703ede8 to
72751e0
Compare
|
@JaydipGabani done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm after nits. Please fix nits.
...ary/pod-security-policy/capabilities/1.1.2/samples/capabilities-demo/example_disallowed.yaml
Outdated
Show resolved
Hide resolved
...brary/pod-security-policy/capabilities/1.1.2/samples/capabilities-demo/example_drop_all.yaml
Outdated
Show resolved
Hide resolved
library/pod-security-policy/capabilities/samples/capabilities-demo/example_drop_all.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: Pierre PIRONIN DUGNE <[email protected]>
2e5aa33 to
4b545ab
Compare
|
@JaydipGabani done and rebased on master. Ready to merge. |
|
@PierrePIRONIN Please run 'make generate generate-website-docs generate-artifacthub-artifacts' to generate the templates and docs to fix CI. |
Signed-off-by: Pierre PIRONIN DUGNE <[email protected]>
f8e012e to
0b1b998
Compare
|
@JaydipGabani done |
|
@JaydipGabani is it ok for you ? |
What this PR does / why we need it:
Fixes a case sensitive test concerning the drop of ALL/all capability.
Which issue(s) does this PR fix (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #668
Special notes for your reviewer: