Skip to content

Conversation

@maxsmythe
Copy link
Contributor

@maxsmythe maxsmythe commented May 29, 2024

What this PR does / why we need it:

Which issue(s) does this PR fix (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #541

Special notes for your reviewer:

@maxsmythe maxsmythe requested a review from a team as a code owner May 29, 2024 23:35
Copy link
Contributor

@JaydipGabani JaydipGabani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stale
Copy link

stale bot commented Aug 3, 2024

This issue/PR has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 3, 2024
@JaydipGabani JaydipGabani removed the stale label Aug 5, 2024
Copy link
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

!has(variables.anyObject.spec.volumes) ? [] :
variables.anyObject.spec.volumes.filter(volume, has(volume.flexVolume))
- name: allowedFlexVolumeDrivers
expression: variables.params.allowedFlexVolumes.map(volume, volume.driver)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
expression: variables.params.allowedFlexVolumes.map(volume, volume.driver)
expression: !has(variables.params.allowedFlexVolumes) ? [] : variables.params.allowedFlexVolumes.map(volume, volume.driver)

to avoid null pointers

expression: variables.params.allowedFlexVolumes.map(volume, volume.driver)
- name: badFlexVolumeNames
expression: |
variables.flexVolumes.map(volume,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
variables.flexVolumes.map(volume,
!has(variables.flexVolumes) ? [] : variables.flexVolumes.map(volume,

to avoid null pointers

@stale
Copy link

stale bot commented Nov 7, 2024

This issue/PR has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 7, 2024
@JaydipGabani JaydipGabani removed the stale label Nov 7, 2024
@stale
Copy link

stale bot commented Jan 9, 2025

This issue/PR has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 9, 2025
@stale
Copy link

stale bot commented Mar 13, 2025

This issue/PR has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 13, 2025
@stale stale bot closed this Mar 27, 2025
@ritazh ritazh reopened this Mar 27, 2025
@stale stale bot removed the stale label Mar 27, 2025
@stale
Copy link

stale bot commented May 26, 2025

This issue/PR has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label May 26, 2025
@ritazh ritazh removed the stale label May 26, 2025
@stale
Copy link

stale bot commented Jul 25, 2025

This issue/PR has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 25, 2025
@sozercan sozercan removed the stale label Jul 25, 2025
@stale
Copy link

stale bot commented Sep 24, 2025

This issue/PR has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add CEL code for PSP Policies in library

5 participants