Skip to content

Conversation

DylanMuir
Copy link

  • Added several Jax and torch CUDA-graph benchmarks for Rockpool
  • Updated Dockerfile to include some missed dependencies
  • Added descriptive assertion error message to benchmarking function

* Updated Dockerfile to include some missed dependencies
* Added descriptive assertion error message to benchmarking function
@DylanMuir DylanMuir marked this pull request as ready for review May 28, 2024 04:12
Copy link
Member

@biphasic biphasic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Dylan, thanks a lot for adding the Rockpool benchmarks. Is there someone in your team that can let them run on a GPU machine to verify that they work? Alternatively I can just merge them, but there is no guarantee that the next person will be able to run them.

@DylanMuir
Copy link
Author

Coming back to this, I'll try to run the benchmarks on an NVIDIA/Docker enabled machine. It's never trivial to get that working 🤣

@neural-loop
Copy link
Member

@DylanMuir Heya Dylan, should we keep this PR opened? The site has changed a lot since this was proposed and I'd be happy to resolve the conflicts to get this merged. That said we haven't done a lot with these benchmarks and the python code really aught to be moved to its own repository if we do want to keep working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants