Mark mpif.h as deprecated #13123
Open
Mark mpif.h as deprecated #13123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i guess you can enable this when |
jsquyres
reviewed
Mar 5, 2025
|
I reworked this patch so that we capture the compiler output and check that it contains the warning we expect. I'm not sure that my m4 is correct so please check. Verified that the warning is enabled with flang-new and disabled with gfortran (which does not print the warning if the include file is in a separate directory). |
|
@janjust Looks like the NVIDIA CI is out of disk space |
we're checking |
jsquyres
reviewed
Mar 11, 2025
devreal
force-pushed
the
deprecate-mpifh
branch
from
5aec98f to
f2720ac
Compare
jsquyres
previously approved these changes
Mar 12, 2025
|
Thanks @jsquyres! Once approved, I will squash everything down to one commit. |
jsquyres
previously approved these changes
Mar 13, 2025
devreal
force-pushed
the
deprecate-mpifh
branch
from
4732e9a to
2a81c9f
Compare
MPI 4.1 has deprecated mpif.h. We add a `#warning` directive that
may be interpreted correctly if the Fortran compiler uses a C-style
preprocessor or generate a warning about a illegal directive, showing
the warning anyway:
```
1 | #warning mpif.h is deprecated since MPI 4.1. Refer to MPI Sec. 19.1.4.
| 1
Error: Illegal preprocessor directive [-Werror]
```
Also adds flang and flang-new to the list of known Fortran compilers.
Signed-off-by: Joseph Schuchart <[email protected]>
devreal
force-pushed
the
deprecate-mpifh
branch
from
2a81c9f to
07f20ca
Compare
jsquyres
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MPI 4.1 deprecated
mpif.hso we may want to start warning about it. Unfortunately, Fortran does not provide a standardized pre-processor so we're at the mercy of the compiler to print the warning. This patch enables the warning by default but allows it to be disabled through--disable-deprecate-mpif-hpassed toconfigure.flang-new prints the warning correctly:
gfortran doesn't:
Unless the include file that contains the warning in the same directory as the file being compiled so that it is not found through the include path:
The file I used for testing:
So in the end gfortran spoils the fun here. Maybe the compiler wrapper could copy a file that contains the warning and is included by
mpif.hbut that is more time than I have right now. Putting this out here in case someone has a smarter idea for how to do it.Fixes #12190.