Skip to content

[v4.1.x]btl/tcp: Correctly report TCP connect errors #13110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: v4.1.x
Choose a base branch
from
+2 −13
Open

[v4.1.x]btl/tcp: Correctly report TCP connect errors #13110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion opal/mca/btl/tcp/btl_tcp_endpoint.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -844,7 +844,7 @@ static int mca_btl_tcp_endpoint_complete_connect(mca_btl_base_endpoint_t* btl_en
opal_show_help("help-mpi-btl-tcp.txt", "client connect fail",
true, opal_process_info.nodename,
getpid(), msg,
strerror(opal_socket_errno), opal_socket_errno);
strerror(so_error), so_error);
free(msg);
mca_btl_tcp_endpoint_close(btl_endpoint);
return OPAL_ERROR;
Expand Down
2 changes: 1 addition & 1 deletion opal/mca/btl/tcp/btl_tcp_proc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -796,7 +796,7 @@ mca_btl_tcp_proc_t* mca_btl_tcp_proc_lookup(const opal_process_name_t *name)
mca_btl_base_endpoint_t *endpoint;
opal_proc_t *opal_proc;

BTL_VERBOSE(("adding tcp proc for unknown peer {%s}",
BTL_VERBOSE(("adding tcp proc for peer {%s}",
OPAL_NAME_PRINT(*name)));

opal_proc = opal_proc_for_name (*name);
Expand Down
11 changes: 0 additions & 11 deletions opal/mca/btl/tcp/help-mpi-btl-tcp.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,14 +156,3 @@ continue properly.

Local host: %s
PID: %d
#
[client connect fail]
WARNING: Open MPI failed to TCP connect to a peer MPI process via
TCP. This should not happen.

Your Open MPI job may now fail.

Local host: %s
PID: %d
Message: %s
Error: %s (%d)