Issue1417_Inlcude implementation for internal floor thicknesses in TwoPort #1419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s' into hfloorcheck
This is useful if an internal wall component is used but connected to the same zone at two sides.
The flooring used in the staircase was IDEAS.Buildings.Validation.Data.Constructions.LightWall, but this includes a layer of insulation with a thickness of 1.003m. Which really doesn't seem to be correct. I changed the types to IDEAS.Examples.PPD12.Data.Floor for now.
This turns out to be important when a surface model is extended and then orientation is redeclared
Model to test internal floor with airflow modelled as ceiling (in all other models it happens to always be modelled as a floor and thus a bunch of the conditions were not in the unittesting)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to include the floor thicknesses in the stack-effect implementation. For this, hFloor needed to be adapted in models that include TwoPortAirflow and have multiple floors. Because of this, the vertical heights check allready needed an update.
Issue #1417