feat(pi-ai): refresh MiniMax-M3 video input and adaptive thinking - #1573
Open
octo-patch wants to merge 2 commits into
Open
feat(pi-ai): refresh MiniMax-M3 video input and adaptive thinking#1573octo-patch wants to merge 2 commits into
octo-patch wants to merge 2 commits into
Conversation
MiniMax-M3 accepts video inputs in addition to text and image, and exposes adaptive and disabled thinking modes over its Anthropic-compatible endpoint. Extend the model input modality vocabulary with "video", teach the generator to emit the video modality and forceAdaptiveThinking for M3, and refresh the generated catalog and its regression test to match.
Contributor
🔴 PR Risk Report — CRITICAL
Affected Systems
File Breakdown
|
Member
|
@octo-patch please create a matching issue for PR |
… video modality
The pi-ai Model.input type now includes "video", so deriving the
discovery provider defaults from the first catalog model no longer
assigns to the narrower ("text" | "image")[] declaration. Reference
Model<Api>["input"] directly so the default stays in sync with the
catalog type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason: MiniMax-M3 accepts video input and supports adaptive and disabled thinking modes, but the generated catalog capped its input at text and image and left it on the budget-based thinking default.
What changed
videoto theModel.inputmodality union and to the catalog validation schema, so a model can declare video input support.["text", "image", "video"]input and withforceAdaptiveThinkingenabled to match its adaptive and disabled thinking modes.models.generated.tsandmodels.generated.json) for MiniMax-M3 on both the global and China providers.MiniMax-M2.7 is intentionally left unchanged, as its parameters already match.
Checks
pnpm --filter @gsd/pi-ai exec vitest --run test/generated-models.test.ts— 14 passed (includes the catalog mirror and validation tests).pnpm --filter @gsd/pi-ai exec tsc -p tsconfig.json --noEmit— clean.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.