feat: set context during provider registration#749
Closed
Conversation
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
beeme1mr
commented
Jan 9, 2024
| await OpenFeature.setProviderAndWait(provider); | ||
| expect(provider.status).toBe(ProviderStatus.READY); | ||
| expect(spy).toBeCalled(); | ||
| expect(spy).toHaveBeenCalled(); |
Member
Author
There was a problem hiding this comment.
toBeCalled has been deprecated.
Member
Author
|
Marking this as a draft until the spec is approved. |
beeme1mr
commented
Jan 26, 2024
| This can be overridden by explicitly setting context during initialization or by references the name used during provider registration. | ||
|
|
||
| ```ts | ||
| OpenFeature.setProvider("clientForCache", new NewCachedProvider(), { isCache: true}); |
Member
Author
|
Closing in favor of #919 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
Related Issues
Fixes #748
Notes
I had to move the logic outside of the abstract class because the client supports named client context, which isn't available in the abstract. I also have to define the overloads on each implementation (web, server) in order for intellisense to work properly.