chore: Updated dependencies and corrected checkstyle violations #1259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
justinabrahms
changed the title
beeme1mr
approved these changes
Jan 3, 2025
aepfli
reviewed
Jan 3, 2025
| @@ -419,7 +419,7 @@ | |||
| <dependency> | |||
| <groupId>com.puppycrawl.tools</groupId> | |||
| <artifactId>checkstyle</artifactId> | |||
| <version>8.45.1</version> | |||
| <version>10.21.0</version> | |||
There was a problem hiding this comment.
Our build is running on java 8, check style 10+ require Java 11 - I think this will not work
aepfli
requested changes
Jan 3, 2025
There was a problem hiding this comment.
Mockito and check style in this pull request version require Java 11 - we are building with Java 8. Hence this will not work.
As target version 1.8 is a requirement, we can think of updating our test build to a newer version, where we are executing those targets, but we are not able to merge this as is
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependency Dashboard
Related Issues
Fixes #89
Notes
"<p>"tag. I have just modified those lines.How to test