-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add traces to ofrep endpoint #1593
base: main
Are you sure you want to change the base?
feat: add traces to ofrep endpoint #1593
Conversation
✅ Deploy Preview for polite-licorice-3db33c canceled.
|
6b44e01
to
77ea788
Compare
This is great! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some limited knowledge about both OpenFeature and feature flagging semconv, please ignore my comments wherever it does not make any sense :)
Overall, I'm wondering this PR should actually add logs for the internal operations instead, only keeping the server span for handling the HTTP request.
Signed-off-by: Simon Schrottner <[email protected]>
77ea788
to
981b927
Compare
Signed-off-by: Simon Schrottner <[email protected]>
thank you for the great insights, i will limit this pr now, to only offer spans, but not adding any kind of additional information. Thank you |
I'm fine with limiting this pr, but I think I agree with @pichlermarc that we should limit span use and add more events (logs) before we release these changes. I think changing the nature of our telemetry to much can cause thrashing for monitoring setups. |
Thanks for working on this @aepfli . What do you think about this? #1593 (comment) |
with this pr, we are now generating traces, beforehand there was nothing - so i think it is a good starting point, especially for the ofrep endpoint, which is often related with a span from another system anyways |
I think this is the right approach. We can easily add spans and custom attributes later once the use case becomes clear. Thanks! |
This PR
our OFREP endpoint was not offering any kind of otel information, now we have traces

Related Issues
Relates: open-telemetry/opentelemetry-demo#2119
Notes
Follow-up Tasks
How to test