feat: adds ability to access original flag keys post-generation #167

kriscoleman · 2025-10-02T20:23:26Z

This PR

Adds the ability to access original flag keys post-generation by implementing fmt.Stringer interface on generated flag structs.

Implements fmt.Stringer interface for all generated flag structs across all supported languages
Adds stringer type and helper in Go templates to return original flag keys
Adds FlagKeys constants class in C# templates for programmatic access to flag keys
Updates all language templates (Go, C#, Java, Node.js, Python, React, NestJS) to include flag key access
Enables developers to access the original flag key string value via .String() method
Useful for logging, debugging, and programmatic flag key access

Related Issues

Closes #109

Notes

This feature allows developers to retrieve the original flag key string from generated flag objects, which is particularly useful for:

Logging and debugging flag evaluations
Programmatic access to flag keys without hardcoding strings
Integration with monitoring and analytics systems

The implementation uses Go's fmt.Stringer interface pattern and similar approaches in other languages to provide a clean API.

How to test

Generate code for any supported language using the CLI
Use the generated flag objects and call .String() method (Go) or access FlagKeys constants (C#)
Verify that the original flag key string is returned
Run the integration tests: cd test/go-integration && go test

Signed-off-by: Kris Coleman <[email protected]>

Adds a help target to the Makefile. This target provides a list of available commands and their descriptions, improving the user experience when interacting with the Makefile. Signed-off-by: Kris Coleman <[email protected]>

GitHub Actions uses Dagger v0.19.0 while locally we were using v0.18.12, causing API incompatibility errors in integration tests. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> Signed-off-by: Kris Coleman <[email protected]>

Adds automatically generated openfeature integration for go. This keeps the integration tests in-sync. Also includes golang 1.24 upgrades Signed-off-by: Kris Coleman <[email protected]>

bbland1 · 2025-10-06T22:42:51Z

@kriscoleman I will hopefully be able to look over this more tomorrow, my computer is having issues and I am having to use a different one but it means setting up some of the basics to look over things like this. 😅 GitHub isn't the best way to read over code for me but looking at it nothing jumped out at me and from what I can tell it does touch on all the points raised in proposed issue.

beeme1mr · 2025-10-07T21:02:48Z

/gemini review

gemini-code-assist

Code Review

This pull request introduces a valuable feature by enabling programmatic access to the original flag keys after code generation, implementing this for all supported languages. The approach is idiomatic for each language, using fmt.Stringer in Go and FlagKeys constants in others. The changes are well-structured, and the Go integration tests have been updated to validate the new functionality. My main feedback is to ensure the C# integration tests are also updated to cover this new feature, as the provided generated file for the test seems to be missing the FlagKeys class.

test/csharp-integration/OpenFeature.g.cs

beeme1mr

It works great except for when the description is omitted from the flag manifest. Please add support for the scenario and I'll approve. Thanks!

go.mod

internal/generators/react/react.tmpl

kriscoleman · 2025-10-10T16:21:43Z

@beeme1mr I fixed the missing flag keys from the csharp .g.cs and also added logic to handle missing descriptions in the generated comments in the clients.

I'm a little uncertain what to use when the descriptions are omitted, so I went with "Flag Key for this flag" in the event the flag description isn't there.

beeme1mr · 2025-10-10T16:28:00Z

I'm a little uncertain what to use when the descriptions are omitted, so I went with "Flag Key for this flag" in the event the flag description isn't there.

That seems like a good approach. We can always change it later since it won't be a breaking change.

beeme1mr · 2025-10-10T16:28:20Z

/gemini review

gemini-code-assist

Code Review

This pull request introduces a valuable feature, enabling developers to access original flag keys from the generated typed clients. The implementation is well-executed and idiomatic for each of the supported languages, using fmt.Stringer in Go and FlagKeys constants in others. The changes are comprehensive, covering templates, golden test files, and integration tests. I've identified a couple of minor areas for improvement concerning formatting consistency in the generated Java code and comment consistency in the Python template to enhance the overall quality.

gemini-code-assist · 2025-10-10T16:30:30Z

internal/cmd/testdata/success_java.golden

         */
        FlagEvaluationDetails<Double> discountPercentageDetails(EvaluationContext ctx);
-
+        


This blank line now contains spaces, which is a minor formatting regression. This issue is repeated for all generated methods in this file. Please adjust the template to output a truly blank line for better code formatting and consistency. This can be fixed by adding a newline before the {{ end }} statement in the loops within internal/generators/java/java.tmpl.

gemini-code-assist · 2025-10-10T16:30:30Z

internal/generators/python/python.tmpl

+class FlagKeys:
+    """Flag key constants for programmatic access"""
+{{- range .Flagset.Flags }}
+    {{ .Key | ToScreamingSnake }} = {{ .Key | Quote }}  # {{ if .Description }}{{ .Description }}{{ else }}Feature flag{{ end }}


For consistency with the other language generators in this PR (e.g., C#, Java, JS), the comment for the flag key constant should be more descriptive. Consider prefixing it with 'Flag key for: ' and using 'this flag' as the fallback for a missing description to align it with other implementations.

{{ .Key | ToScreamingSnake }} = {{ .Key | Quote }} # Flag key for: {{ if .Description }}{{ .Description }}{{ else }}this flag{{ end }}

… descriptions Signed-off-by: Kris Coleman <[email protected]>

kriscoleman force-pushed the feat/generate-stringers branch from 0ec59d2 to 6b428d1 Compare October 6, 2025 15:21

kriscoleman added 2 commits October 6, 2025 11:31

feat: adds ability to access original flag keys post-generation

3d6a463

Signed-off-by: Kris Coleman <[email protected]>

feat: adds makefile help target

747f745

Adds a help target to the Makefile. This target provides a list of available commands and their descriptions, improving the user experience when interacting with the Makefile. Signed-off-by: Kris Coleman <[email protected]>

kriscoleman force-pushed the feat/generate-stringers branch from 6b428d1 to 747f745 Compare October 6, 2025 15:32

kriscoleman force-pushed the feat/generate-stringers branch from dfb5100 to 5d22130 Compare October 6, 2025 15:53

fix: go integration tests

1930e7f

Adds automatically generated openfeature integration for go. This keeps the integration tests in-sync. Also includes golang 1.24 upgrades Signed-off-by: Kris Coleman <[email protected]>

kriscoleman force-pushed the feat/generate-stringers branch from def5d0a to 1930e7f Compare October 6, 2025 16:19

kriscoleman marked this pull request as ready for review October 6, 2025 16:21

kriscoleman requested review from bbland1 and beeme1mr October 6, 2025 18:15

kriscoleman mentioned this pull request Oct 6, 2025

Generate Stringers #109

Open

georgesdugue mentioned this pull request Oct 7, 2025

feat: manifest command group for adding and listing flags in manifest #168

Open

gemini-code-assist bot reviewed Oct 7, 2025

View reviewed changes

test/csharp-integration/OpenFeature.g.cs Show resolved Hide resolved

beeme1mr reviewed Oct 8, 2025

View reviewed changes

go.mod Show resolved Hide resolved

internal/generators/react/react.tmpl Outdated Show resolved Hide resolved

kriscoleman force-pushed the feat/generate-stringers branch from 61730e5 to 496fac8 Compare October 10, 2025 16:22

beeme1mr approved these changes Oct 10, 2025

View reviewed changes

gemini-code-assist bot reviewed Oct 10, 2025

View reviewed changes

chore: addressed pr commits about csharp missing keyflags and omitted…

262191d

… descriptions Signed-off-by: Kris Coleman <[email protected]>

kriscoleman force-pushed the feat/generate-stringers branch from 496fac8 to 262191d Compare October 10, 2025 20:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: adds ability to access original flag keys post-generation #167

feat: adds ability to access original flag keys post-generation #167

kriscoleman commented Oct 2, 2025 •

edited

Loading

Uh oh!

bbland1 commented Oct 6, 2025

Uh oh!

beeme1mr commented Oct 7, 2025

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

beeme1mr left a comment

Uh oh!

Uh oh!

Uh oh!

kriscoleman commented Oct 10, 2025

Uh oh!

beeme1mr commented Oct 10, 2025

Uh oh!

beeme1mr commented Oct 10, 2025

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Oct 10, 2025

Uh oh!

gemini-code-assist bot Oct 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		*/
		FlagEvaluationDetails<Double> discountPercentageDetails(EvaluationContext ctx);

feat: adds ability to access original flag keys post-generation #167

Are you sure you want to change the base?

feat: adds ability to access original flag keys post-generation #167

Conversation

kriscoleman commented Oct 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

This PR

Related Issues

Notes

How to test

Uh oh!

bbland1 commented Oct 6, 2025

Uh oh!

beeme1mr commented Oct 7, 2025

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

beeme1mr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

kriscoleman commented Oct 10, 2025

Uh oh!

beeme1mr commented Oct 10, 2025

Uh oh!

beeme1mr commented Oct 10, 2025

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

kriscoleman commented Oct 2, 2025 •

edited

Loading