Skip to content

Conversation

@jakubsikorski
Copy link
Contributor

@jakubsikorski jakubsikorski commented Nov 3, 2025

📝 Description

Adds cluster analytics deployment, similar to how it's run in Docker Compose. WebUI enabled defaults to false.
Adds port forwarding for Kind config so it can be externally accessed when enabled.

Changes default port from 5000 to 9443. 5000 is widely used by many apps, including Docker registry.

Deletes some unused values in the chart.

image

ITEP-80607

✨ Type of Change

Select the type of change your PR introduces:

  • 🐞 Bug fix – Non-breaking change which fixes an issue
  • 🚀 New feature – Non-breaking change which adds functionality
  • 🔨 Refactor – Non-breaking change which refactors the code base
  • 💥 Breaking change – Changes that break existing functionality
  • 📚 Documentation update
  • 🔒 Security update
  • 🧪 Tests
  • 🚂 CI

🧪 Testing Scenarios

Describe how the changes were tested and how reviewers can test them too:

  • ✅ Tested manually
  • 🤖 Ran automated end-to-end tests

✅ Checklist

Before submitting the PR, ensure the following:

  • 🔍 PR title is clear and descriptive
  • 📝 For internal contributors: If applicable, include the JIRA ticket number (e.g., ITEP-123456) in the PR title. Do not include full URLs
  • 💬 I have commented my code, especially in hard-to-understand areas
  • 📄 I have made corresponding changes to the documentation
  • ✅ I have added tests that prove my fix is effective or my feature works

@jakubsikorski jakubsikorski self-assigned this Nov 3, 2025
@jakubsikorski jakubsikorski marked this pull request as ready for review November 3, 2025 11:46
@jakubsikorski jakubsikorski requested a review from Copilot November 3, 2025 11:46
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request adds cluster analytics deployment capabilities to Kubernetes, similar to the existing Docker Compose setup. The primary change is introducing a new clusterAnalytics service with configurable WebUI support, while also updating the default port from 5000 to 9443 to avoid conflicts with commonly used applications like Docker registry.

  • Adds Kubernetes deployment templates for cluster analytics with optional WebUI
  • Changes default port from 5000 to 9443 across all configurations
  • Removes unused configuration values from the Helm chart

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
sample_data/docker-compose-dl-streamer-example.yml Updates commented port mapping to reflect new default port
kubernetes/template/kind-config.template Adds port forwarding for cluster analytics WebUI
kubernetes/scenescape-chart/values.yaml Adds cluster analytics configuration and removes unused values
kubernetes/scenescape-chart/templates/cluster-analytics/service.yaml Creates Kubernetes service for cluster analytics with conditional WebUI exposure
kubernetes/scenescape-chart/templates/cluster-analytics/deployment.yaml Creates Kubernetes deployment for cluster analytics with configurable WebUI
kubernetes/Makefile Adds cluster analytics image to build and push targets
cluster_analytics/tools/webui/web_ui.py Updates default port parameters in WebUI methods
cluster_analytics/tools/webui/README.md Updates documentation with new port references
cluster_analytics/src/cluster_analytics_context.py Updates default port in ClusterAnalyticsContext constructor
cluster_analytics/src/cluster_analytics.py Updates argument parser defaults and help text for new port

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@dmytroye dmytroye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakubsikorski jakubsikorski enabled auto-merge (squash) November 4, 2025 09:41
@jakubsikorski jakubsikorski merged commit 8020f9c into release-2025.2 Nov 4, 2025
25 checks passed
@jakubsikorski jakubsikorski deleted the cluster-analytics-deployment branch November 4, 2025 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants