-
Notifications
You must be signed in to change notification settings - Fork 34
Add cluster analytics deployment #556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request adds cluster analytics deployment capabilities to Kubernetes, similar to the existing Docker Compose setup. The primary change is introducing a new clusterAnalytics service with configurable WebUI support, while also updating the default port from 5000 to 9443 to avoid conflicts with commonly used applications like Docker registry.
- Adds Kubernetes deployment templates for cluster analytics with optional WebUI
- Changes default port from 5000 to 9443 across all configurations
- Removes unused configuration values from the Helm chart
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| sample_data/docker-compose-dl-streamer-example.yml | Updates commented port mapping to reflect new default port |
| kubernetes/template/kind-config.template | Adds port forwarding for cluster analytics WebUI |
| kubernetes/scenescape-chart/values.yaml | Adds cluster analytics configuration and removes unused values |
| kubernetes/scenescape-chart/templates/cluster-analytics/service.yaml | Creates Kubernetes service for cluster analytics with conditional WebUI exposure |
| kubernetes/scenescape-chart/templates/cluster-analytics/deployment.yaml | Creates Kubernetes deployment for cluster analytics with configurable WebUI |
| kubernetes/Makefile | Adds cluster analytics image to build and push targets |
| cluster_analytics/tools/webui/web_ui.py | Updates default port parameters in WebUI methods |
| cluster_analytics/tools/webui/README.md | Updates documentation with new port references |
| cluster_analytics/src/cluster_analytics_context.py | Updates default port in ClusterAnalyticsContext constructor |
| cluster_analytics/src/cluster_analytics.py | Updates argument parser defaults and help text for new port |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
📝 Description
Adds cluster analytics deployment, similar to how it's run in Docker Compose. WebUI enabled defaults to false.
Adds port forwarding for Kind config so it can be externally accessed when enabled.
Changes default port from
5000to9443. 5000 is widely used by many apps, including Docker registry.Deletes some unused values in the chart.
ITEP-80607
✨ Type of Change
Select the type of change your PR introduces:
🧪 Testing Scenarios
Describe how the changes were tested and how reviewers can test them too:
✅ Checklist
Before submitting the PR, ensure the following: