Add datasets and models to the upgrade script

[saratpoluri]

📝 Description

Provide a clear summary of the changes and the context behind them. Describe what was changed, why it was needed, and how the changes address the issue or add value.

✨ Type of Change

Select the type of change your PR introduces:

• 🐞 Bug fix – Non-breaking change which fixes an issue
• 🚀 New feature – Non-breaking change which adds functionality
• 🔨 Refactor – Non-breaking change which refactors the code base
• 💥 Breaking change – Changes that break existing functionality
• 📚 Documentation update
• 🔒 Security update
• 🧪 Tests
• 🚂 CI

🧪 Testing Scenarios

Describe how the changes were tested and how reviewers can test them too:

• ✅ Tested manually
• 🤖 Ran automated end-to-end tests

✅ Checklist

Before submitting the PR, ensure the following:

• 🔍 PR title is clear and descriptive
• 📝 For internal contributors: If applicable, include the JIRA ticket number (e.g., ITEP-123456) in the PR title. Do not include full URLs
• 💬 I have commented my code, especially in hard-to-understand areas
• 📄 I have made corresponding changes to the documentation
• ✅ I have added tests that prove my fix is effective or my feature works

[Copilot]

Pull Request Overview

This pull request implements comprehensive upgrade functionality for Intel® SceneScape, extending beyond database upgrades to include model and dataset management during the upgrade process.

Key changes:

• Expanded upgrade script to handle models and datasets in addition to database migration
• Renamed upgrade tool from upgrade-database to upgrade-scenescape to reflect broader scope
• Updated documentation and build scripts to reference the new upgrade process

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
percebro/src/open_pose.py	Complete file removal - OpenPose model implementation deleted
manager/tools/upgrade-scenescape	Added functions to copy models and datasets to Docker volumes during upgrade
docs/user-guide/How-to-upgrade.md	Updated documentation to reference new upgrade script and added volume verification steps
deploy.sh	Changed script references from upgrade-database to upgrade-scenescape
Makefile	Renamed targets and updated help text to reflect broader upgrade scope

[Copilot]

The script forcibly removes existing volumes without checking if they contain important data. Consider adding a backup or confirmation step before removing volumes to prevent accidental data loss.

Suggested change

	docker volume rm scenescape_vol-models 2>/dev/null || true
	if docker volume inspect scenescape_vol-models >/dev/null 2>&1; then
	echo "WARNING: This will remove the existing 'scenescape_vol-models' volume and all its data."
	read -p "Are you sure you want to continue? [y/N]: " confirm
	if [[ "$confirm" != "y" && "$confirm" != "Y" ]]; then
	echo "Aborting models volume initialization."
	return 1
	fi
	docker volume rm scenescape_vol-models
	fi

[Copilot]

Similar to the models volume, the datasets volume is removed without verification. This could lead to data loss if the volume contains user data that should be preserved during upgrade.

Suggested change

	log_message "Initializing datasets volume..."
	local backup_dir="backup_datasets_$(date +%Y%m%d_%H%M%S)"
	log_message "Checking for existing data in scenescape_vol-datasets volume..."
	# Use a temporary container to check if the volume is non-empty
	docker run --rm \
	-v scenescape_vol-datasets:/data \
	alpine:latest /bin/sh -c "ls -A /data" > /tmp/datasets_volume_contents.txt 2>/dev/null || true
	if [ -s /tmp/datasets_volume_contents.txt ]; then
	echo "WARNING: Existing data found in scenescape_vol-datasets volume:"
	cat /tmp/datasets_volume_contents.txt
	echo "Do you want to back up the existing datasets before removal? [y/N]"
	read -r backup_choice
	if [ "$backup_choice" = "y" ] || [ "$backup_choice" = "Y" ]; then
	mkdir -p "$backup_dir"
	docker run --rm \
	-v scenescape_vol-datasets:/data \
	-v ${PWD}/$backup_dir:/backup \
	alpine:latest /bin/sh -c "cp -r /data/* /backup/"
	echo "Backup completed: $backup_dir"
	fi
	echo "Do you want to delete the existing datasets volume? This will permanently remove all data. [y/N]"
	read -r delete_choice
	if [ ! "$delete_choice" = "y" ] && [ ! "$delete_choice" = "Y" ]; then
	echo "Aborting datasets volume removal."
	return 1
	fi
	fi
	rm -f /tmp/datasets_volume_contents.txt
	log_message "Removing and re-creating datasets volume..."

[Copilot]

The temporary container creation doesn't handle the case where a container with the same name already exists. Consider adding docker rm -f ${temp_container} 2>/dev/null || true before creating the container to prevent conflicts.

[Copilot]

Same issue as with the models container - potential naming conflicts if a container with the same name already exists from a previous failed run.

Suggested change

	# Remove any existing container with the same name to avoid naming conflicts
	docker rm -f ${temp_container} 2>/dev/null || true

[Copilot]

The copy command will fail if the source directory /source/models/ is empty or doesn't contain any files, as the shell expansion /* will not match anything. Consider using cp -r /source/models/. /dest/models/ or adding a check for directory contents first.

Suggested change

	docker exec ${temp_container} /bin/sh -c "cp -r /source/models/* /dest/models/"
	docker exec ${temp_container} /bin/sh -c "cp -r /source/models/. /dest/models/"

[Copilot]

Same issue as with the models copy - the command will fail if /source/datasets/ is empty. The shell glob /* expansion requires at least one file to match.

Suggested change

	docker exec ${temp_container} /bin/sh -c "cp -r /source/datasets/* /dest/datasets/"
	docker exec ${temp_container} /bin/sh -c "if [ \"\$(ls -A /source/datasets)\" ]; then cp -r /source/datasets/* /dest/datasets/; else echo 'No datasets to copy.'; fi"