[ITEP-27359] Removal of optional ProjectID in ARM #125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guptagunjan
requested review from
SeanCondon,
adibrastegarnia,
ajaythakurintel,
badhrinathpa,
cgoea,
pudelkoM and
scottmbaker
as code owners
|
Going to run component tests to see if we don't have any issues in the tests but over LGTM |
SeanCondon
reviewed
Jun 9, 2025
| # Versions are expected to follow Semantic Versioning (https://semver.org/) | ||
|
|
||
| version: 2.4.4 | ||
| version: 2.4.5 |
There was a problem hiding this comment.
I think this should be -dev too like the others. But why not make a release 2.4.5 out of it?
SeanCondon
reviewed
Jun 10, 2025
There was a problem hiding this comment.
It looks like TestListVirtualMachineWorkloads is failing in tests since projectID is not present
adibrastegarnia
added
run-arm-component-tests
and removed
run-arm-component-tests
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove ProjectID set as optional from ARM. Enforce everywhere to check ProjectID and return error if no active project ID is found.
Changes
List the changes you have made.
Additional Information
Include any additional information, such as how to test your changes.
Checklist