Open
Conversation
AppVeyor CI references Visual Studio 2019 and SDL2 dependencies that are not needed for the library build. The fork is built from source in the RoundTable Iron Bank container pipeline, not via AppVeyor. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
The CMakeLists changes in 7cca7d4 referenced these source files but the files themselves were never staged. This commit adds the actual implementations and ignores build-vs/ and install/ output dirs. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
Adds the test sources, sample data, utilities, and result/analysis docs that test/CMakeLists.txt (committed in 7cca7d4) was already referencing. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix missing SignalPdu and TransmitterPdu: Added SignalPdu.h/.cpp and TransmitterPdu.h/.cpp to the CMake build -- these files existed in the source tree but were never compiled. Also added PDU basic test suite.
Fix duplicate fields: Removed duplicate _originatingID and _receivingID fields from 5 Simulation Management PDUs (AcknowledgePdu, ActionRequestPdu, ActionResponsePdu, CreateEntityPdu, RemoveEntityPdu). These fields were already inherited from the parent class SimulationManagementFamilyPdu -- the duplicates caused double-marshaling, producing malformed wire format.