fix: commentable_ids should be list of ids rather then a comma separated string#812
Merged
xitij2000 merged 1 commit intoviadanna/sumac/offlinefrom Jan 19, 2026
Merged
Conversation
…ted string note: this can be dropped when upgrading to teak
farhaanbukhsh
approved these changes
Jan 17, 2026
Member
farhaanbukhsh
left a comment
There was a problem hiding this comment.
👍
✅ I tested this on the sandbox
Created a post in one unit
Tested that it isn't visible in any other unit
✅ I read through the code
❌ I checked for accessibility issues
❌ Includes documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This along with upgrading the openedx-forum package to v0.3.2 or above will fix the issue where in-context discussions are not filtered to the current unit.
note: this can be dropped when upgrading to teak
Testing instructions:
private ref: https://tasks.opencraft.com/browse/BB-10387