feat: add ability to override middlewares for recurring nudges#790
Merged
kaustavb12 merged 5 commits intoopencraft-release/sumac.1from Aug 18, 2025
Merged
Conversation
openedx/core/djangoapps/schedules/management/commands/__init__.py
Outdated
Show resolved
Hide resolved
809563e to
0786504
Compare
samuelallan72
requested changes
Aug 14, 2025
Member
samuelallan72
left a comment
There was a problem hiding this comment.
Thanks @kaustavb12 . I just had some queries about the command args.
openedx/core/djangoapps/schedules/management/commands/__init__.py
Outdated
Show resolved
Hide resolved
openedx/core/djangoapps/schedules/management/commands/__init__.py
Outdated
Show resolved
Hide resolved
openedx/core/djangoapps/schedules/management/commands/__init__.py
Outdated
Show resolved
Hide resolved
Member
|
Aside from the queries about the arguments, everything looks good to me! :) |
b0b3394 to
21323ab
Compare
samuelallan72
approved these changes
Aug 18, 2025
Member
samuelallan72
left a comment
There was a problem hiding this comment.
👍 (just a couple of small nits, but otherwise all good!)
- I tested this: tested in the sandbox
- I read through the code
- I checked for accessibility issues
- Includes documentation
- @kaustavb12 unsure if this counts - do we need to do this? I guess we would want to upstream this patch too. [ ] Added to the Code Drift project board (for backports)
openedx/core/djangoapps/schedules/management/commands/__init__.py
Outdated
Show resolved
Hide resolved
openedx/core/djangoapps/schedules/management/commands/__init__.py
Outdated
Show resolved
Hide resolved
ca90c97 to
a58135a
Compare
kaustavb12
added a commit
that referenced
this pull request
Aug 23, 2025
* feat: add ability to override middlewares for recurring nudges * feat: add ability to run command for all sites
Cup0fCoffee
pushed a commit
that referenced
this pull request
Oct 12, 2025
* feat: add ability to override middlewares for recurring nudges * feat: add ability to run command for all sites (cherry picked from commit 759e8f0)
Cup0fCoffee
pushed a commit
that referenced
this pull request
Oct 14, 2025
* feat: add ability to override middlewares for recurring nudges * feat: add ability to run command for all sites (cherry picked from commit 759e8f0)
viadanna
pushed a commit
that referenced
this pull request
Feb 3, 2026
* feat: add ability to override middlewares for recurring nudges * feat: add ability to run command for all sites (cherry picked from commit 759e8f0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR brings two changes to all the management command based on SendEmailBaseCommand:
Testing instructions
course_org_filtersetup for each site to map it to a unique org.Other information
Private Ref : BB-9883