fix: retrieve course ID when rendering DiscussionXBlock#783
Closed
Agrendalath wants to merge 2 commits intoopencraft-release/sumac.1from
Closed
fix: retrieve course ID when rendering DiscussionXBlock#783Agrendalath wants to merge 2 commits intoopencraft-release/sumac.1from
Agrendalath wants to merge 2 commits intoopencraft-release/sumac.1from
Conversation
Agrendalath
force-pushed
the
agrendalath/fix-discussions-xblock
branch
from
a149836 to
54a3a4a
Compare
Member
|
@Agrendalath Your upstream PR - openedx#36753 - has been closed in favor of openedx#37245. Can this PR be closed and dropped? |
Member
Author
|
@Cup0fCoffee, we can close this (please do not delete the branch, though), but we need to backport the upstream fix into our Teak branch. |
Without this, the `forum` package gets `None` as a course key and fails with `InvalidKeyError` when checking the forum backend.
Agrendalath
force-pushed
the
agrendalath/fix-discussions-xblock
branch
from
54a3a4a to
5df8ebe
Compare
Member
Context on this: this branch is still being used on a production instance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a Sumac backport of openedx#36753.