Skip to content

feat: disallow edits to units in courses that are sourced from a library [FC-0083] #774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pomegranited merged 7 commits into from
Apr 24, 2025
Merged

feat: disallow edits to units in courses that are sourced from a library [FC-0083] #774

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
391e3af
feat: disallow edits to units in courses that are sourced from a library
rpenido Apr 21, 2025
29324b9
feat: use existing can_edit flag
pomegranited Apr 24, 2025
2cb23de
Merge branch 'navin/fal-4077/link-unit' into rpenido/fal-4112/disallo…
pomegranited Apr 24, 2025
fee529b
Merge remote-tracking branch 'opencraft/rpenido/fal-4112/disallow-edi…
pomegranited Apr 24, 2025
7e1168d
fix: use xblock["upstream_info"] instead of "upstream"
pomegranited Apr 24, 2025
9181236
Merge remote-tracking branch 'opencraft/navin/fal-4077/link-unit' int…
pomegranited Apr 24, 2025
6235d61
Merge remote-tracking branch 'opencraft/chris/FAL-4075-get-unit-updst…
pomegranited Apr 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions cms/djangoapps/contentstore/views/preview.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,8 +299,14 @@ def _studio_wrap_xblock(xblock, view, frag, context, display_name_only=False):
if selected_groups_label:
selected_groups_label = _('Access restricted to: {list_of_groups}').format(list_of_groups=selected_groups_label) # lint-amnesty, pylint: disable=line-too-long
course = modulestore().get_course(xblock.location.course_key)
can_edit = context.get('can_edit', True)
can_add = context.get('can_add', True)

if root_xblock and root_xblock.upstream and str(root_xblock.upstream).startswith('lct:'):
can_edit = False
can_add = False
else:
can_edit = context.get('can_edit', True)
can_add = context.get('can_add', True)

# Is this a course or a library?
is_course = xblock.context_key.is_course
tags_count_map = context.get('tags_count_map')
Expand All @@ -315,7 +321,7 @@ def _studio_wrap_xblock(xblock, view, frag, context, display_name_only=False):
'is_root': is_root,
'is_reorderable': is_reorderable,
'can_edit': can_edit,
'can_edit_visibility': context.get('can_edit_visibility', is_course),
'can_edit_visibility': can_edit and context.get('can_edit_visibility', is_course),
'course_authoring_url': settings.COURSE_AUTHORING_MICROFRONTEND_URL,
'is_loading': context.get('is_loading', False),
'is_selected': context.get('is_selected', False),
Expand Down
13 changes: 7 additions & 6 deletions cms/templates/studio_xblock_wrapper.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,12 +211,13 @@
<span data-tooltip="${_('Drag to reorder')}" class="drag-handle action"></span>
</li>
% endif
% elif not show_inline:
<li class="action-item action-edit action-edit-view-only">
<a href="#" class="edit-button action-button">
<span class="action-button-text">${_("Details")}</span>
</a>
</li>
% if not show_inline:
<li class="action-item action-edit action-edit-view-only">
<a href="#" class="edit-button action-button">
<span class="action-button-text">${_("Details")}</span>
</a>
</li>
% endif
% endif
% endif
</ul>
Expand Down
Loading