fix: update prereq state for all#64
Draft
DanielVZ96 wants to merge 1 commit intoasu-moe/redwood-cssfrom
Draft
Conversation
8d6b9bf to
df645f2
Compare
DanielVZ96
commented
Sep 5, 2024
| case COURSE_BLOCK_NAMES.sequential.id: | ||
| dispatch(configureCourseSubsectionQuery(currentItem.id, currentSection.id, ...arg)); | ||
| dispatch(configureCourseSubsectionQuery(currentItem.id, currentSection.id, ...arg)).then(() => { | ||
| dispatch(fetchCourseOutlineIndexQuery(courseId)); |
Author
There was a problem hiding this comment.
This will reload all sections after a subsection is updated. fixes the issue, but I think there could be a more elegant solution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites don't update for all sections when a subsection is set as prerequisite, only for its own section. This is because the prerequisites list is part of the state of each configure modal instead of the global state. Because of this, when prerequisites change (and sections), the whole course outline state needs to be reloaded.
Here's a video of the issue:
Screencast.from.09-03-2024.05.51.58.PM.webm
Testing instructions
0. setup tutor
tvm project init tutor-eshe v18.1.3 && cd tutor-eshe && source .tvm/bin/activatetutor-eshe/plugins/mfe_config.ymland thtutor mounts add frontend-app-course-authoringtutor dev launchtutor dev do importdemocoursetutor dev do createuser --staff --superuser staff staff@example.com -p staffTest