Repository navigation
fix(lib): namespace and escape BundlerKey.withEnv entries - #618
Open
eduardomourar wants to merge 1 commit into
Open
eduardomourar wants to merge 1 commit into
eduardomourar wants to merge 1 commit into
Conversation
withEnv emitted plain k=v parts in the same namespace as add(), so a labelled add() part and a withEnv() entry could collide into the same key. Prefix entries with env= and escape = inside the key and value so neither an add() part nor another env entry can produce the same key. Fixes open-constructs#546
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Fixes #546
Description
withEnv emitted plain k=v parts in the same namespace as add(), so a labelled add() part and a withEnv() entry could collide into the same key. Prefix entries with env= and escape = inside the key and value so neither an add() part nor another env entry can produce the same key.
Checklist