Repository navigation
feat(cli): defer bundler builds for stacks not targeted by cli commands - #617
Open
eduardomourar wants to merge 2 commits into
Open
eduardomourar wants to merge 2 commits into
eduardomourar wants to merge 2 commits into
Conversation
Adding it as a bundled dependency broke `npm pack` during the cdktn
package step in CI ("Exit handler never called!"). Stack selectors
only need `*`/`?` wildcards, so match them with a small inline regex
translator instead of a new dependency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Fixes #583
Description
diff,deploy,destroy, andoutputnow pass their stack selector into synth, so the app knows which stacks this run will actually use.TerraformAssetskips its (deferred,SOURCE-hashed) bundler build for a stack outside that selector, instead of bundling every stack's assets on every run. It still writes that stack's manifest entry, and leaves its existing staged output as is.The CLI forwards the selector through a new
BUNDLING_STACKS_CONTEXT_KEYcontext value.stackRequiresBundling()matches a stack name against it using the same glob patterns the CLI's own--stackselectors accept (minimatch, now a dependency ofcdktn).Dependency stacks are not auto-included — only the stacks named on the command line are bundled. Resolving dependencies needs the manifest this synth produces, so it is not available yet.
Checklist