Repository navigation
chore(tests): lint Jest tests with eslint-plugin-jest - #577
Open
X-Guardian wants to merge 2 commits into
Open
X-Guardian wants to merge 2 commits into
X-Guardian wants to merge 2 commits into
Conversation
X-Guardian
force-pushed
the
chore/eslint-plugin-jest
branch
from
November 11, 2026 10:06
3ed58d9 to
ca1398c
Compare
X-Guardian
marked this pull request as ready for review
November 11, 2026 10:57
jsteinich
approved these changes
Nov 11, 2026
X-Guardian
force-pushed
the
chore/eslint-plugin-jest
branch
from
November 13, 2026 09:10
ca1398c to
879c7a3
Compare
Contributor
|
Could you drop
|
X-Guardian
force-pushed
the
chore/eslint-plugin-jest
branch
from
November 13, 2026 15:05
879c7a3 to
0b6a026
Compare
Contributor
Author
|
Oops, done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Description
This PR adds
eslint-plugin-jestas a root dev dependency and applies itsflat/recommendedconfig to**/*.test.tsin the sharedeslint.config.mjs.Package configs register their own test wrappers with the plugin:
testIf*aliases fromtest/helper/capabilities.tscount as test blocks forno-standalone-expect.onTf1_6AndNewerinmodule-generator.test.tsbecomes acond ? test : test.skipalias, and counts as a test block. The gated test's title states the Terraform >= 1.6.0 requirement.waitForcounts as an assertion forexpect-expect.exec()timeout table inutil.test.tsruns through anitOnLinuxalias, anditOnLinux.eachcounts as a test block.Test changes:
cli-core/src/test/models/deploy-machine.test.ts: thedone-callback tests await xstate'swaitForinstead.dependency-manager.test.tsandprebuilt-providers.test.tscheck for unused registry mocks inafterEachwith undici'sassertNoPendingInterceptors().expectcalls become unconditional:watch.test.tssplits its failure and abort cases into two tests.telemetry.test.tssplits its attribute table into forwarded and omitted cases, and its gating test asserts the exact list of emitted metric names.error-reporting.test.tsandinit.test.tsassert on computed values.cdktn/test/terraform-hcl-module.test.tsasserts the duplicate-alias error withtoThrow.cdktn/test/app.test.ts:stringMatching.CDKTF_CONTEXTtest is renamed for what it checks:CDKTF_CONTEXTtakes precedence over app context.cdktn/test/provider-functions.test.tsdrops a test that duplicated the preceding one with a weaker assertion.empty-provider-resources.test.tsasserts on the generated files.commons/src/config.test.tsdrops an unused one.hcl2cdk/test/convertProject.test.tskeeps itsdescribe.skipwith a disable comment pointing at test(hcl2cdk): convertProject fixture uses a module with a removed Terraform language experiment #461.Checklist