fix(36): helmvalues.NewAuthClient does not panick over HelmRegistry credentials - #46
Merged
Conversation
…s.NewAuthClient panics over HelmCredentials within the OCM configuration Signed-off-by: Lukas Grundmann <lukas.grundmann@opendefense.cloud>
… would require a CredentialProvider within helmvalues.NewAuthClient, but have no effect on ocm-kit's functionality. Signed-off-by: Lukas Grundmann <lukas.grundmann@opendefense.cloud>
lukasgr90
force-pushed
the
fix/36-do-not-panic-over-ocm-config-with-helm-registry-creds
branch
from
August 26, 2026 14:36
e3a734d to
76be72e
Compare
Signed-off-by: Lukas Grundmann <lukas.grundmann@opendefense.cloud>
Signed-off-by: Lukas Grundmann <lukas.grundmann@opendefense.cloud>
iljaweis
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
helmvalues.NewAuthClient now filters credentials from the load OCM configuration, which would require a CredentialPluginProvider. All of them are of no use for ocm-kit's further on. Thus this fix approach is simpler than implementation of a CredentialPluginProvider, which covers currently & in future supported credential types.
Which issue(s) this PR fixes
Fixes #36