fix: remove dependency on ocm-kit/flake.nix for Go tools version - #45
Merged
Merged
Conversation
lukasgr90
approved these changes
Aug 26, 2026
lukasgr90
left a comment
lukasgr90
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me (also looking at the documentation of the changed Github action setup-go, https://github.com/actions/setup-go)
Signed-off-by: Ilja Weis <ilja.weis@opendefense.cloud>
Signed-off-by: Ilja Weis <ilja.weis@opendefense.cloud>
Signed-off-by: Ilja Weis <ilja.weis@opendefense.cloud>
Signed-off-by: Ilja Weis <ilja.weis@opendefense.cloud>
Signed-off-by: Ilja Weis <ilja.weis@opendefense.cloud>
Signed-off-by: Ilja Weis <ilja.weis@opendefense.cloud>
…es (open-component-model#42) * fix: helm-kit now also produces the component descriptor + localReference based OCI reference for ociImages, which originally were include into the CV as local OCI image layout and an input. test: Extended E2E test by a test case, which embedds a local OCI image into the component version and then tries to use ocm-kit to get the native access to the image, which is based on the component descriptor's OCI reference and the image's digest / localReference. Signed-off-by: Lukas Grundmann <lukas.grundmann@opendefense.cloud> * fix: LocalBlobv2OCIReference does not introduce the scheme oci:// anymore, but does just take the repoBaseURL as passed from outside. Signed-off-by: Lukas Grundmann <lukas.grundmann@opendefense.cloud> * test: Made test case definitions within TestLocalBlobv2OCIReference more explicit using a high order functions to check the results of the function under test. Signed-off-by: Lukas Grundmann <lukas.grundmann@opendefense.cloud> --------- Signed-off-by: Lukas Grundmann <lukas.grundmann@opendefense.cloud> Signed-off-by: Ilja Weis <ilja.weis@opendefense.cloud>
jakobmoellerdev
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
The ocm-kit build process takes the go version from
ocm-kit/flake.nix, which then requires that updates to the go version need to happen both inocm-kit/go.modandocm-kit/flake.nix. Since the devshell is not used, this makes updates unnecessarily complicated. So this PR removes this dependency and selects the go version fromocm-kit/go.mod.Which issue(s) this PR fixes
Fixes breaking build in #20