🌱 add grpc subscribers metric. #148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: morvencao <[email protected]> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
morvencao
force-pushed
the
br_grpc_subscribers_metric
branch
from
55a90fb to
262b3de
Compare
Signed-off-by: morvencao <[email protected]> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
|
/assign @qiujian16 @skeeey @clyang82 |
clyang82
reviewed
Sep 22, 2025
| var grpcCEMetricsCommonLabels = []string{ | ||
| grpcCEMetricsClusterLabel, | ||
| grpcCEMetricsDataTypeLabel, | ||
| grpcCEMetricsMethodLabel, |
There was a problem hiding this comment.
for grpc_server_ce_subscribers, no need method label.
for other grpc_server_ce_* metrics, need method label, see it in grpcCEMetricsHandlerLabels
|
/lgtm |
skeeey
reviewed
Sep 24, 2025
| "sync" | ||
| "time" | ||
|
|
||
| "open-cluster-management.io/sdk-go/pkg/cloudevents/server/grpc/heartbeat" |
There was a problem hiding this comment.
we also need to consider the heartbeat metrics, but we can use the other pr to handle it
|
LGTM |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: morvencao, qiujian16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 9633a0b
into
open-cluster-management-io:main
12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
Summary
original_sourcelabel for cloudevents metric of source side (for agent side, still keep it).Related issue(s)
open-cluster-management-io/enhancements#153
Fixes #