Skip to content

ManifestWorkReplicaSet Rollout Plugin #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 1 commit into from
Dec 3, 2025
Merged

ManifestWorkReplicaSet Rollout Plugin #160

openshift-merge-bot merged 1 commit into from
Dec 3, 2025

Conversation

@youngbupark
Copy link
Contributor

@youngbupark youngbupark commented Oct 28, 2025

  • This is the initial draft for supporting rollout plugin in ManifestWorkReplicaSet Work Controller
  • Note: rollback will be added when we propose MWRS automatic rollback enhancement.

@youngbupark youngbupark mentioned this pull request Oct 28, 2025
Open
youngbupark
youngbupark commented Oct 28, 2025
View reviewed changes
enhancements/sig-architecture/231-manifestworkreplicaset-rollout-plugin/README.md
The following service defines the contract between Work Controller and the plugin. Each call must be idempotent, stateless, and time-bounded (≤30 s) to ensure consistent controller reconciliation. Plugin server must implement the following APIs. The helpers to implement server and clients will be implemented in [ocm/sdk-go](https://github.com/open-cluster-management-io/sdk-go) repository.

```proto
// RolloutPluginService is the service for the rollout plugin.
Copy link
Contributor Author

@youngbupark youngbupark Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is the initial commit of gRPC server proto - open-cluster-management-io/sdk-go#154

Note: The implementation can change as we develop.

@youngbupark youngbupark changed the title KEP: ManifestWorkReplicaSet Rollout Plugin ManifestWorkReplicaSet Rollout Plugin Oct 28, 2025
@youngbupark youngbupark marked this pull request as ready for review October 29, 2025 02:00
@openshift-ci openshift-ci bot requested review from deads2k and qiujian16 October 29, 2025 02:00
qiujian16
qiujian16 reviewed Oct 29, 2025
View reviewed changes
@youngbupark youngbupark mentioned this pull request Nov 12, 2025
Merged
qiujian16
qiujian16 reviewed Nov 18, 2025
View reviewed changes
enhancements/sig-architecture/227-manifestworkreplicaset-rollout-plugin/README.md Outdated
# optional. secretRef is the reference for ca
secretRef:
name: my-rollout-ca
namespace: default
Copy link
Member

@qiujian16 qiujian16 Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

namespace might not be needed. The secret has to be put in the open-cluster-management-hub ns.

@youngbupark youngbupark force-pushed the add-plugin branch 3 times, most recently from 95aca1a to 7edf2ba Compare December 2, 2025 03:44
youngbupark
youngbupark commented Dec 2, 2025
View reviewed changes
enhancements/sig-architecture/231-manifestworkreplicaset-rollout-plugin/metadata.yaml
- "@qiujian16"
- "@haoqing0110"
approvers:
- "@qiujian16"
Copy link
Contributor Author

@youngbupark youngbupark Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qiujian16 @haoqing0110 I have added your names here.

@haoqing0110
Copy link
Member

haoqing0110 commented Dec 2, 2025

@youngbupark Thanks for the contribution! The proposal looks good to me.

Just one minor nit: I noticed a few 'TBD' and 'WIP' markers left in the text. You might want to clean those up.

@qiujian16
Copy link
Member

qiujian16 commented Dec 3, 2025

/approve

@openshift-ci
Copy link

openshift-ci bot commented Dec 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, youngbupark

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Dec 3, 2025
@youngbupark
Initial PR for rollout plugin
c85d923 
Signed-off-by: Young Bu Park <[email protected]>
@qiujian16
Copy link
Member

qiujian16 commented Dec 3, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 3, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit a14f0f3 into open-cluster-management-io:main Dec 3, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qiujian16 qiujian16 qiujian16 left review comments

@deads2k deads2k Awaiting requested review from deads2k

+2 more reviewers

@haoqing0110 haoqing0110 haoqing0110 left review comments

@annelaucg annelaucg annelaucg left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@qiujian16 qiujian16

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@youngbupark @haoqing0110 @qiujian16 @annelaucg