Skip to content

Upgrade Go version from 1.22 to 1.23 in go.mod and update workflowles to reflect the new version. #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2025
Merged

Upgrade Go version from 1.22 to 1.23 in go.mod and update workflowles to reflect the new version. #227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/go-postsubmit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,16 +9,16 @@ on:

env:
# Common versions
GO_VERSION: '1.22'
GO_REQUIRED_MIN_VERSION: ''
GO_VERSION: "1.23"
GO_REQUIRED_MIN_VERSION: ""

jobs:
images:
name: images
runs-on: ubuntu-latest
strategy:
matrix:
arch: [ amd64, arm64 ]
arch: [amd64, arm64]
steps:
- name: checkout code
uses: actions/checkout@v4
Expand All @@ -44,7 +44,7 @@ jobs:
image-manifest:
name: image manifest
runs-on: ubuntu-latest
needs: [ images ]
needs: [images]
steps:
- name: checkout code
uses: actions/checkout@v4
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/go-presubmit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ on:

env:
# Common versions
GO_VERSION: "1.22"
GO_VERSION: "1.23"
GO_REQUIRED_MIN_VERSION: ""

jobs:
Expand Down
16 changes: 8 additions & 8 deletions .github/workflows/go-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,13 @@ name: GoRelease
on:
push:
tags:
- 'v*.*.*'
- "v*.*.*"
env:
# Common versions
GO_VERSION: '1.22'
GO_REQUIRED_MIN_VERSION: ''
GO_VERSION: "1.23"
GO_REQUIRED_MIN_VERSION: ""
GITHUB_REF: ${{ github.ref }}
CHART_NAME: 'cluster-proxy'
CHART_NAME: "cluster-proxy"

jobs:
env:
Expand Down Expand Up @@ -37,10 +37,10 @@ jobs:
images:
name: images
runs-on: ubuntu-latest
needs: [ env ]
needs: [env]
strategy:
matrix:
arch: [ amd64, arm64 ]
arch: [amd64, arm64]
steps:
- name: checkout code
uses: actions/checkout@v4
Expand All @@ -66,7 +66,7 @@ jobs:
image-manifest:
name: image manifest
runs-on: ubuntu-latest
needs: [ env, images ]
needs: [env, images]
steps:
- name: checkout code
uses: actions/checkout@v4
Expand All @@ -90,7 +90,7 @@ jobs:
release:
name: release
runs-on: ubuntu-latest
needs: [ env, image-manifest ]
needs: [env, image-manifest]
steps:
- name: checkout code
uses: actions/checkout@v4
Expand Down
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ vet: ## Run go vet against code.
go vet ./...

golint:
go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.54.1
go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.64.8
golangci-lint run --timeout=3m ./...

verify: fmt vet golint
Expand Down
2 changes: 1 addition & 1 deletion cmd/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Build the manager binary
FROM golang:1.22 as builder
FROM golang:1.23 as builder

WORKDIR /workspace

Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module open-cluster-management.io/cluster-proxy

go 1.22.0
go 1.23.6

require (
github.com/onsi/ginkgo/v2 v2.17.1
Expand Down