Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Added support for sigs.k8s.io about api #361

Conversation

gnana997
Copy link
Contributor

Summary

Added support for Cluster Properties through sigs.k8s.io/about-api.

  • To use the feature in ocm to add support for cluster properties

Related issue(s)

open-cluster-management-io/ocm#838

@gnana997
Copy link
Contributor Author

Hi @qiujian16 , I have added new CRD and support for clusterProperties including the feature gate to add support for clusterProperties in ocm package.

Can you please let me know if I miss anything?

Thanks!

@gnana997 gnana997 changed the title added support for sigs.k8s.io about api 🚀 Added support for sigs.k8s.io about api Mar 17, 2025
@gnana997 gnana997 changed the title 🚀 Added support for sigs.k8s.io about api [feature] Added support for sigs.k8s.io about api Mar 17, 2025
@gnana997 gnana997 changed the title [feature] Added support for sigs.k8s.io about api ✨ Added support for sigs.k8s.io about api Mar 17, 2025
Copy link
Member

@qiujian16 qiujian16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only need to add feature gate in api repo. Not necessary to define the API here.

@gnana997 gnana997 force-pushed the added-cluster-props branch from b76b7d6 to 47e73c9 Compare March 18, 2025 15:37
@gnana997 gnana997 requested a review from qiujian16 March 18, 2025 15:39
@qiujian16
Copy link
Member

/approve

Copy link
Contributor

openshift-ci bot commented Mar 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnana997, qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@qiujian16
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 19, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit b4fb4a6 into open-cluster-management-io:main Mar 19, 2025
10 checks passed
@gnana997 gnana997 deleted the added-cluster-props branch March 19, 2025 14:36
@gnana997
Copy link
Contributor Author

Hi @qiujian16 , Can you please release the new version? I will use it in the ocm package to support the cluster property informer based on the feature gate.
Thanks!

@qiujian16
Copy link
Member

commonly we do not release with a single change. You can update the go mod by specifying the commit on the main branch
something like
go get open-cluster-management.io/api@{commit id}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants