-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Added support for sigs.k8s.io about api #361
✨ Added support for sigs.k8s.io about api #361
Conversation
Hi @qiujian16 , I have added new CRD and support for clusterProperties including the feature gate to add support for clusterProperties in ocm package. Can you please let me know if I miss anything? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We only need to add feature gate in api repo. Not necessary to define the API here.
Signed-off-by: gnana997 <[email protected]>
b76b7d6
to
47e73c9
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gnana997, qiujian16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: gnana997 <[email protected]>
Signed-off-by: gnana997 <[email protected]>
Signed-off-by: gnana997 <[email protected]>
…into added-cluster-props
/lgtm |
b4fb4a6
into
open-cluster-management-io:main
Hi @qiujian16 , Can you please release the new version? I will use it in the ocm package to support the cluster property informer based on the feature gate. |
commonly we do not release with a single change. You can update the go mod by specifying the commit on the main branch |
Summary
Added support for Cluster Properties through sigs.k8s.io/about-api.
Related issue(s)
open-cluster-management-io/ocm#838