shift from tolerance for thd to tolerance for RH in the diffusional growth adaptivity scheme
#868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ber in arabas_and_shima_2017/test_conservation
|
Stale pull request message |
|
Stale pull request message |
|
Stale pull request message |
|
Stale pull request message |
|
Stale pull request message |
…ber in arabas_and_shima_2017/test_conservation
|
Stale pull request message |
|
The original reason for the change proposed here was the unstable behavior of the condensation solver in parcel simulations. In the meantime, this was also addressed in #746. Switching from thd to RH as the tolerance control variable is likely still a good idea, but since we were not able to renorm the tests robustly, it seems that it comes with some tradeoffs. Closing for now. |
slayoo
changed the title
thd to tolerance for RH in the diffusional growth adaptivity scheme
|
this is now part of #1681 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.