Skip to content

Conversation

yoctoyotta1024
Copy link

No description provided.

Copy link

codecov bot commented Jul 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.69%. Comparing base (a921acc) to head (44e51fc).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #609   +/-   ##
=======================================
  Coverage   92.69%   92.69%           
=======================================
  Files          39       39           
  Lines        1697     1697           
=======================================
  Hits         1573     1573           
  Misses        124      124           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@slayoo
Copy link
Member

slayoo commented Jul 22, 2025

@Sfonxu (as we talked about it today), the key issue here is that without the change the code would not work, but the change is in a conditional branch that never gets executed on CI - which is a bug by itself. In #611, we suggest to split the example into two separate ones, so that the conditional expression goes away, and both "bin" and "bulk" code branches would be executed. Hence, suggest introducing this "split" in this PR - let's look at it on Thu.

thanks @yoctoyotta1024 for reporting it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants