-
Notifications
You must be signed in to change notification settings - Fork 22
Comparison with PyPDE: Integrate Benchmarking and Compatibility Analysis #576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ations, and clean up for better readability
examples/PyMPDATA_examples/comparison_against_pypde_2025/diffusion_2d.py
Outdated
Show resolved
Hide resolved
tests/smoke_tests/comparison_against_pypde_2025/test_comparison.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes in cartesian_grid-1.ipynb were proposed.
examples/PyMPDATA_examples/comparison_against_pypde_2025/cartesian_grid-1.ipynb
Outdated
Show resolved
Hide resolved
examples/PyMPDATA_examples/comparison_against_pypde_2025/cartesian_grid-1.ipynb
Show resolved
Hide resolved
examples/PyMPDATA_examples/comparison_against_pypde_2025/cartesian_grid-1.ipynb
Outdated
Show resolved
Hide resolved
examples/PyMPDATA_examples/comparison_against_pypde_2025/diffusion_2d.py
Outdated
Show resolved
Hide resolved
examples/PyMPDATA_examples/comparison_against_pypde_2025/diffusion_2d.py
Outdated
Show resolved
Hide resolved
examples/PyMPDATA_examples/comparison_against_pypde_2025/diffusion_2d.py
Outdated
Show resolved
Hide resolved
tests/smoke_tests/comparison_against_pypde_2025/test_comparison.py
Outdated
Show resolved
Hide resolved
tests/smoke_tests/comparison_against_pypde_2025/test_comparison.py
Outdated
Show resolved
Hide resolved
CI reports this failure (https://github.com/open-atmos/PyMPDATA/actions/runs/15552679887/job/43825446170?pr=576):
|
I tried downgrading py-pde, but the earliest version that doesn't have the numba requirement is 0.36.0, and our solution uses some features that are not present in that version. |
so let's run these tests only for Python 3.13 (using |
This pull request introduces a detailed comparison between PyMPDATA and the PyPDE framework. It adds benchmarking scripts, analysis notebooks, and documentation updates to help users evaluate performance and compatibility between the two libraries. Key changes include: