Skip to content

Conversation

pepe5p
Copy link

@pepe5p pepe5p commented Jun 9, 2025

This pull request introduces a detailed comparison between PyMPDATA and the PyPDE framework. It adds benchmarking scripts, analysis notebooks, and documentation updates to help users evaluate performance and compatibility between the two libraries. Key changes include:

  • New scripts for running side-by-side benchmarks with PyPDE
  • Jupyter notebooks illustrating test cases and results
  • Test for compatibility with PyPDE

@pepe5p pepe5p marked this pull request as ready for review June 9, 2025 15:16
@pepe5p pepe5p marked this pull request as draft June 9, 2025 15:17
@pepe5p pepe5p marked this pull request as ready for review June 10, 2025 20:13
Copy link

@piotrkubala piotrkubala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes in cartesian_grid-1.ipynb were proposed.

@slayoo
Copy link
Member

slayoo commented Jun 18, 2025

CI reports this failure (https://github.com/open-atmos/PyMPDATA/actions/runs/15552679887/job/43825446170?pr=576):

  File "/home/runner/work/PyMPDATA/PyMPDATA/examples/PyMPDATA_examples/comparison_against_pypde_2025/diffusion_2d.py", line 69
    type Two2DiffusionSolution = npt.NDArray[np.float64]
         ^
SyntaxError: invalid syntax

@Eniterusx
Copy link

Eniterusx commented Jun 21, 2025

image
I have a problem with dependencies. If python's version is 3.11 or lower, the requries numba's version is lower than 0.59 required by py-pde. Because of that, the pylint test can't install the dependencies correctly. Genuinely no idea how to solve this.

@slayoo
Copy link
Member

slayoo commented Jun 21, 2025

image I have a problem with dependencies. If python's version is 3.11 or lower, the requries numba's version is lower than 0.59 required by py-pde. Because of that, the pylint test can't install the dependencies correctly. Genuinely no idea how to solve this.

could we work with an older version of py-pde on CI?

@Eniterusx
Copy link

Eniterusx commented Jun 21, 2025

could we work with an older version of py-pde on CI?

I tried downgrading py-pde, but the earliest version that doesn't have the numba requirement is 0.36.0, and our solution uses some features that are not present in that version.

@slayoo
Copy link
Member

slayoo commented Jun 21, 2025

could we work with an older version of py-pde on CI?

I tried downgrading py-pde, but the earliest version that doesn't have the numba requirement is 0.36.0, and our solution uses some features that are not present in that version.

so let's run these tests only for Python 3.13 (using pytest.skipif for older Pythons) and in setup.py, if CI env var is set, let's only add the dependency on py-pde if we run on Python 3.13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants