Add forward declarations header and refactor includes #194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce `FwdDecls.hpp` to centralize class and template forward declarations in the Oasis namespace. Updated `Visit.hpp` to use `FwdDecls.hpp`, removing redundant declarations. Adjusted `CMakeLists.txt` to include the new header.
matthew-mccall
force-pushed
the
feature-fwddecl
branch
from
6f84924 to
d8b0b67
Compare
… dependency in `Concepts.hpp`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the way forward declarations are managed in the Oasis codebase. The main change is the introduction of a new header file,
FwdDecls.hpp, which centralizes all forward declarations for Oasis types and templates. This improves maintainability and reduces duplication across headers.Header organization and codebase maintainability:
Oasis/FwdDecls.hppcontaining all forward declarations for Oasis types and templates, replacing scattered declarations in other headers.include/CMakeLists.txtto includeOasis/FwdDecls.hppin the build configuration.Code cleanup:
Oasis/Visit.hppand replaced them with a single#include "FwdDecls.hpp"statement.IntroduceFwdDecls.hppto centralize class and template forward declarations in the Oasis namespace. UpdatedVisit.hppto useFwdDecls.hpp, removing redundant declarations. AdjustedCMakeLists.txtto include the new header.