Skip to content

Conversation

zhihangdeng
Copy link
Collaborator

@zhihangdeng zhihangdeng commented Sep 17, 2025

Description

This pull request introduces new Helm values files for deploying services on openEuler-based CPU images in both the AudioQnA and CodeGen projects. The main goal is to override image tags and repositories to ensure compatibility with openEuler, and to selectively enable or disable services based on the deployment needs.

Helm values for openEuler compatibility:

  • Added cpu-openeuler-values.yaml to AudioQnA/kubernetes/helm, setting image tags to latest-openeuler and updating repositories for services like vllm, while enabling/disabling services as appropriate.
  • Added cpu-openeuler-values.yaml to CodeGen/kubernetes/helm, overriding image tags and repositories for all enabled services to use openEuler-compatible images, and configuring backend settings for text generation and embeddings.
  • Added cpu-tgi-openeuler-values.yaml to CodeGen/kubernetes/helm, specifically enabling the TGI service with openEuler images and disabling VLLM, while updating other service images and backend settings for openEuler compatibility.

Issues

#2264

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

List the newly introduced 3rd party dependency if exists.

Tests

Describe the tests that you ran to verify your changes.

@Copilot Copilot AI review requested due to automatic review settings September 17, 2025 02:13
Copy link

github-actions bot commented Sep 17, 2025

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Files

None

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds openEuler platform support for the AudioQnA Helm deployment by introducing a specialized values file. The configuration enables specific services compatible with openEuler while disabling others, and standardizes on openEuler-specific image tags.

  • Adds cpu-openeuler-value.yaml with openEuler-specific service configurations
  • Enables vllm and speecht5 services while disabling tgi and gpt-sovits
  • Configures all enabled services to use latest-openeuler image tags

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines 6 to 8
image:
tag: latest-openeuler

Copy link
Preview

Copilot AI Sep 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The global latest-openeuler tag may not apply to all services. Consider removing this global setting since individual services already specify their own tags explicitly (lines 17, 22, 29, 35).

Suggested change
image:
tag: latest-openeuler

Copilot uses AI. Check for mistakes.

enabled: true
image:
repository: openeuler/vllm-cpu
tag: 0.10.1-oe2403lts
Copy link
Preview

Copilot AI Sep 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The vllm service uses a specific versioned tag 0.10.1-oe2403lts while other services use latest-openeuler. Consider using consistent tagging strategy across all services for better maintainability and predictable deployments.

Suggested change
tag: 0.10.1-oe2403lts
tag: latest-openeuler

Copilot uses AI. Check for mistakes.

@zhihangdeng zhihangdeng force-pushed the audioqna branch 2 times, most recently from 5b5cbc5 to 1ff1c73 Compare September 17, 2025 02:40
@zhihangdeng zhihangdeng changed the title Add openEuler Helm values for AudioQnA Add openEuler Helm values for AudioQnA and CodeGen Sep 17, 2025
@zhihangdeng zhihangdeng force-pushed the audioqna branch 5 times, most recently from 78dd724 to 1e27848 Compare September 17, 2025 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants