Skip to content

Fix for insecure audio file path #2268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix for insecure audio file path #2268

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
82c8b7b
Fix for insecure audio file path
mhbuehler Sep 11, 2025
b4a2a2d
Merge branch 'main' into melanie/fix_insecure_audio_path
mhbuehler Sep 19, 2025
e50af7b
Merge branch 'main' into melanie/fix_insecure_audio_path
ZePan110 Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion MultimodalQnA/ui/gradio/multimodalqna_ui_gradio.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,8 +383,17 @@ def ingest_with_caption(filepath, text_caption, audio_caption, request: gr.Reque
is_audio_caption = audio_caption is not None
if is_audio_caption:
verified_audio_path = os.path.normpath(audio_caption)
if not verified_audio_path.startswith(tmp_upload_folder):
print("Found malicious audio file path!")
yield (
gr.Textbox(
visible=True,
value="Your uploaded audio file's path is not allowed. Please upload a valid file.",
)
)
return
caption_basename = "{}{}".format(os.path.splitext(basename)[0], os.path.splitext(verified_audio_path)[-1])
caption_file = audio_caption
caption_file = verified_audio_path
else:
caption_basename = "{}.txt".format(os.path.splitext(basename)[0])
caption_file = os.path.join(static_dir, caption_basename)
Expand Down
Loading