Skip to content

Conversation

ZePan110
Copy link
Collaborator

@ZePan110 ZePan110 commented Sep 4, 2025

Description

refine UI test for ChatQnA

Issues

List the issue or RFC link this PR is working on. If there is no such link, please mark it as n/a.

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

List the newly introduced 3rd party dependency if exists.

Tests

Describe the tests that you ran to verify your changes.

Signed-off-by: ZePan110 <[email protected]>
@Copilot Copilot AI review requested due to automatic review settings September 4, 2025 07:22
@ZePan110 ZePan110 added the WIP label Sep 4, 2025
Copy link

github-actions bot commented Sep 4, 2025

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Files

None

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR consolidates UI testing by creating a dedicated test script and removing duplicated frontend validation code from multiple test files. The refactoring extracts the UI testing logic into a centralized location while maintaining the same test functionality.

  • Creates a new dedicated UI test script (test_ui.sh) with frontend validation functionality
  • Removes duplicate validate_frontend functions from 12 existing test scripts
  • Integrates the new UI test into the CI workflow

Reviewed Changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.

File Description
ChatQnA/tests/test_ui.sh New dedicated UI test script with complete frontend validation workflow
ChatQnA/tests/test_compose_*.sh Removes duplicate validate_frontend functions from 12 test files
.github/workflows/_run-docker-compose.yml Adds UI test script to CI workflow execution

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Signed-off-by: ZePan110 <[email protected]>
Signed-off-by: ZePan110 <[email protected]>
Signed-off-by: ZePan110 <[email protected]>
@ZePan110 ZePan110 removed the WIP label Sep 19, 2025
@ZePan110 ZePan110 merged commit 301b98b into main Sep 23, 2025
71 of 72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants