-
Notifications
You must be signed in to change notification settings - Fork 317
refine UI test #2238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refine UI test #2238
Conversation
Signed-off-by: ZePan110 <[email protected]>
Dependency Review✅ No vulnerabilities or license issues found.Scanned FilesNone |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR consolidates UI testing by creating a dedicated test script and removing duplicated frontend validation code from multiple test files. The refactoring extracts the UI testing logic into a centralized location while maintaining the same test functionality.
- Creates a new dedicated UI test script (
test_ui.sh
) with frontend validation functionality - Removes duplicate
validate_frontend
functions from 12 existing test scripts - Integrates the new UI test into the CI workflow
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
ChatQnA/tests/test_ui.sh | New dedicated UI test script with complete frontend validation workflow |
ChatQnA/tests/test_compose_*.sh | Removes duplicate validate_frontend functions from 12 test files |
.github/workflows/_run-docker-compose.yml | Adds UI test script to CI workflow execution |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: ZePan110 <[email protected]>
Signed-off-by: ZePan110 <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: ZePan110 <[email protected]>
Signed-off-by: ZePan110 <[email protected]>
Signed-off-by: ZePan110 <[email protected]>
Signed-off-by: ZePan110 <[email protected]>
Signed-off-by: ZePan110 <[email protected]>
Signed-off-by: ZePan110 <[email protected]>
Signed-off-by: ZePan110 <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: ZePan110 <[email protected]>
Signed-off-by: ZePan110 <[email protected]>
Description
refine UI test for ChatQnA
Issues
List the issue or RFC link this PR is working on. If there is no such link, please mark it as
n/a
.Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
List the newly introduced 3rd party dependency if exists.
Tests
Describe the tests that you ran to verify your changes.